Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BoundaryInfo methods for surface or lattice crossing #3295

Open
pshriwise opened this issue Feb 6, 2025 · 0 comments
Open

Create BoundaryInfo methods for surface or lattice crossing #3295

pshriwise opened this issue Feb 6, 2025 · 0 comments

Comments

@pshriwise
Copy link
Contributor

pshriwise commented Feb 6, 2025

Description

Whenever we cross a surface the following boilerplate code appears

if (boundary.lattice_translation[0] != 0 ||
    boundary.lattice_translation[1] != 0 ||
    boundary.lattice_translation[2] != 0) {
  ...
}

A method like bool BoundaryInfo::lattice_crossing() would be useful and more clear.

Alternatives

Leave well enough alone.

Compatibility

Should be an internal refactor, no compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant