Skip to content

Commit 55973fa

Browse files
authored
(feat) Patient banner styling refinements (#1284)
* (feat) Patient banner styling refinements Refines the Patient Banner layout and visual consistency with the following changes: - Sets an explicit height for the Actions menu button to ensure consistent vertical alignment (explicitly sets it to `3rem` instead of `2.5rem` from Carbon). - Adds a top border to the contact details panel, eliminating the need for consuming components to add their own. - Adds row gap to demographic elements (patient name and identifiers) to maintain consistent spacing when their content overflows. - Adds right-edge padding to the patient info section to prevent the overflow menu from touching the container edge. These changes support https://openmrs.atlassian.net/browse/O3-4114, which will refactor Patient Management repo's patient banner implementations to use shared banner components from the styleguide. * Update styling token
1 parent 4ec0632 commit 55973fa

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

packages/framework/esm-styleguide/src/custom-overflow-menu/custom-overflow-menu.module.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
@use '@carbon/colors';
2+
@use '@carbon/layout';
23
@import '@openmrs/esm-styleguide/src/vars';
34

45
.container {
56
width: auto;
67
height: auto;
8+
9+
:global(.cds--overflow-menu__trigger) {
10+
min-height: layout.$spacing-09;
11+
}
712
}
813

914
.menu {

packages/framework/esm-styleguide/src/patient-banner/contact-details/patient-banner-contact-details.module.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
.deceased {
88
color: $text-02;
99
width: 100%;
10+
border-top: 1px solid $ui-03;
1011
}
1112

1213
.heading {

packages/framework/esm-styleguide/src/patient-banner/patient-info/patient-banner-patient-info.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
.patientInfo {
4242
display: flex;
4343
flex-direction: column;
44-
padding: layout.$spacing-05 0 layout.$spacing-05 0;
44+
padding: layout.$spacing-05 layout.$spacing-03 layout.$spacing-05 0;
4545
width: 100%;
4646
}
4747

@@ -50,7 +50,7 @@
5050
color: $text-02;
5151
display: flex;
5252
align-items: center;
53-
column-gap: layout.$spacing-02;
53+
gap: layout.$spacing-02;
5454
margin-top: layout.$spacing-02;
5555
flex-wrap: wrap;
5656
}

0 commit comments

Comments
 (0)