fix: changes from review

Author: ascorbic

Diff for: index.js

@@ -30,7 +30,6 @@ module.exports = {
     // Populates the correct config if needed
     await verifyBuildTarget({ netlifyConfig, packageJson, failBuild })
 
-    // Because we memoize nextConfig, we need to do this after the write file
     const nextConfig = await getNextConfig(utils.failBuild)
 
     if (nextConfig.images.domains.length !== 0 && !process.env.NEXT_IMAGE_ALLOWED_DOMAINS) {

Diff for: test/index.js

@@ -49,6 +49,7 @@ const useFixture = async function (fixtureName) {
 // In each test, we change cwd to a temporary directory.
 // This allows us not to have to mock filesystem operations.
 beforeEach(async () => {
+  // This is so we can test the target setting code
   delete process.env.NEXT_PRIVATE_TARGET
   delete require.cache[require.resolve('next/dist/telemetry/ci-info')]
   delete require.cache[require.resolve('next/dist/next-server/server/config')]
@@ -85,15 +86,13 @@ describe('preBuild()', () => {
   })
 
   test('run plugin if the app has next export in an unused script', async () => {
-    process.env.hi = 'ok'
     await plugin.onPreBuild({
       netlifyConfig,
       packageJson: { ...DUMMY_PACKAGE_JSON, scripts: { export: 'next export' } },
       utils,
       constants: {},
     })
     expect(process.env.NEXT_PRIVATE_TARGET).toBe('serverless')
-    // expect(await pathExists('next.config.js')).toBeTruthy()
   })
 
   test('do nothing if app has static html export in toml/ntl config', async () => {