Skip to content

Commit ac0c205

Browse files
authored
ci: use a single, consistent ntl auth token (#572)
* ci: use a single, consistent ntl auth token We have both `NETLIFY_TOKEN` and `NETLIFY_AUTH_TOKEN` configured in CI and we're using both across various workflows. This ensures only one is used, so we can delete the other. * ci: change E2E_PAGE_SITE_ID from secret to var I changed this in the GitHub settings.
1 parent af10944 commit ac0c205

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Diff for: .github/workflows/e2e-report.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ on:
99
type: boolean
1010

1111
env:
12-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
13-
NETLIFY_SITE_ID: ${{ secrets.E2E_PAGE_SITE_ID }}
12+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
13+
NETLIFY_SITE_ID: ${{ vars.E2E_PAGE_SITE_ID }}
1414
GH_TOKEN: ${{ github.token }}
1515

1616
jobs:

Diff for: .github/workflows/run-tests.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
run: npm ci
7171
- name: 'Netlify Login'
7272
env:
73-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
73+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
7474
run: |
7575
# TODO(serhalp) Unpin version once
7676
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
@@ -99,7 +99,7 @@ jobs:
9999
- name: Run Playwright tests
100100
run: npm run test:ci:e2e -- --shard=${{ matrix.shard }}/5
101101
env:
102-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
102+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
103103
NEXT_VERSION: ${{ matrix.version }}
104104
NEXT_RESOLVED_VERSION: ${{ steps.resolve-next-version.outputs.version }}
105105
- name: Upload blob report to GitHub Actions Artifacts
@@ -171,7 +171,7 @@ jobs:
171171
- name: 'Unit and integration tests'
172172
run: npm run test:ci:unit-and-integration -- --shard=${{ matrix.shard }}/8
173173
env:
174-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
174+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
175175
NEXT_VERSION: ${{ matrix.version }}
176176
NEXT_RESOLVED_VERSION: ${{ steps.resolve-next-version.outputs.version }}
177177
TEMP: ${{ github.workspace }}/..
@@ -206,7 +206,7 @@ jobs:
206206
run: npm run build
207207
- name: 'Netlify Login'
208208
env:
209-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
209+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
210210
run: |
211211
# TODO(serhalp) Unpin version once
212212
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
@@ -222,7 +222,7 @@ jobs:
222222
- name: 'Smoke tests'
223223
run: npm run test:ci:smoke
224224
env:
225-
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
225+
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
226226
NEXT_VERSION: ${{ matrix.version }}
227227
NEXT_RESOLVED_VERSION: ${{ steps.resolve-next-version.outputs.version }}
228228

0 commit comments

Comments
 (0)