Skip to content

Commit ac52f3f

Browse files
piehpieh
committed
test: add test cases to i18n middleware with exclusions
1 parent 28217d4 commit ac52f3f

10 files changed

+242
-0
lines changed

‎tests/e2e/edge-middleware.test.ts

+120
Original file line numberDiff line numberDiff line change
@@ -69,3 +69,123 @@ test('json data rewrite works', async ({ middlewarePages }) => {
6969

7070
expect(data.pageProps.message).toBeDefined()
7171
})
72+
73+
// those tests use `fetch` instead of `page.goto` intentionally to avoid potential client rendering
74+
// hiding any potential edge/server issues
75+
test.describe('Middleware with i18n and excluding paths', () => {
76+
const DEFAULT_LOCALE = 'en'
77+
78+
// those tests hit paths ending with `/json` which has special handling in middleware
79+
// to return JSON response from middleware itself
80+
test.describe('Middleware response path', () => {
81+
test('should match on non-localized not excluded path', async ({
82+
middlewareI18nExcludedPaths,
83+
}) => {
84+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/json`)
85+
86+
expect(response.headers.get('x-test-used-middleware')).toBe('true')
87+
expect(response.status).toBe(200)
88+
89+
const { nextUrlPathname, nextUrlLocale } = await response.json()
90+
91+
expect(nextUrlPathname).toBe('/json')
92+
expect(nextUrlLocale).toBe(DEFAULT_LOCALE)
93+
})
94+
95+
test('should match on localized not excluded path', async ({ middlewareI18nExcludedPaths }) => {
96+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/fr/json`)
97+
98+
expect(response.headers.get('x-test-used-middleware')).toBe('true')
99+
expect(response.status).toBe(200)
100+
101+
const { nextUrlPathname, nextUrlLocale } = await response.json()
102+
103+
expect(nextUrlPathname).toBe('/json')
104+
expect(nextUrlLocale).toBe('fr')
105+
})
106+
107+
test('should NOT match on non-localized excluded path', async ({
108+
middlewareI18nExcludedPaths,
109+
}) => {
110+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/api/json`)
111+
112+
expect(response.headers.get('x-test-used-middleware')).not.toBe('true')
113+
114+
// we are not matching middleware, so we will be served raw JSON response from `pages/api/[[...catchall]].ts`
115+
expect(response.status).toBe(200)
116+
117+
const { params } = await response.json()
118+
119+
expect(params).toMatchObject({ catchall: ['json'] })
120+
})
121+
})
122+
123+
// those tests hit paths that don't end with `/json` so they should be passed through to origin
124+
test.describe('Middleware passthrough', () => {
125+
function extractDataFromHtml(html: string): Record<string, any> {
126+
const match = html.match(/<pre>(?<rawInput>[^<]+)<\/pre>/)
127+
if (!match || !match.groups?.rawInput) {
128+
console.error('<pre> not found in html input', {
129+
html,
130+
})
131+
throw new Error('Failed to extract data from HTML')
132+
}
133+
134+
const { rawInput } = match.groups
135+
const unescapedInput = rawInput.replaceAll('&quot;', '"')
136+
try {
137+
return JSON.parse(unescapedInput)
138+
} catch (originalError) {
139+
console.error('Failed to parse JSON', {
140+
originalError,
141+
rawInput,
142+
unescapedInput,
143+
})
144+
}
145+
throw new Error('Failed to extract data from HTML')
146+
}
147+
148+
test('should match on non-localized not excluded path', async ({
149+
middlewareI18nExcludedPaths,
150+
}) => {
151+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/html`)
152+
153+
expect(response.headers.get('x-test-used-middleware')).toBe('true')
154+
expect(response.status).toBe(200)
155+
expect(response.headers.get('content-type')).toMatch(/text\/html/)
156+
157+
const html = await response.text()
158+
const { locale, params } = extractDataFromHtml(html)
159+
160+
expect(params).toMatchObject({ catchall: ['html'] })
161+
expect(locale).toBe(DEFAULT_LOCALE)
162+
})
163+
164+
test('should match on localized not excluded path', async ({ middlewareI18nExcludedPaths }) => {
165+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/fr/html`)
166+
167+
expect(response.headers.get('x-test-used-middleware')).toBe('true')
168+
expect(response.status).toBe(200)
169+
expect(response.headers.get('content-type')).toMatch(/text\/html/)
170+
171+
const html = await response.text()
172+
const { locale, params } = extractDataFromHtml(html)
173+
174+
expect(params).toMatchObject({ catchall: ['html'] })
175+
expect(locale).toBe('fr')
176+
})
177+
178+
test('should NOT match on non-localized excluded path', async ({
179+
middlewareI18nExcludedPaths,
180+
}) => {
181+
const response = await fetch(`${middlewareI18nExcludedPaths.url}/api/html`)
182+
183+
expect(response.headers.get('x-test-used-middleware')).not.toBe('true')
184+
expect(response.status).toBe(200)
185+
186+
const { params } = await response.json()
187+
188+
expect(params).toMatchObject({ catchall: ['html'] })
189+
})
190+
})
191+
})

‎tests/fixtures/middleware-i18n-excluded-paths/middleware.ts

+34
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import { NextResponse } from 'next/server'
2+
import type { NextRequest } from 'next/server'
3+
4+
export async function middleware(request: NextRequest) {
5+
const url = request.nextUrl
6+
7+
// if path ends with /json we create response in middleware, otherwise we pass it through
8+
// to next server to get page or api response from it
9+
const response = url.pathname.includes('/json')
10+
? NextResponse.json({
11+
requestUrlPathname: new URL(request.url).pathname,
12+
nextUrlPathname: request.nextUrl.pathname,
13+
nextUrlLocale: request.nextUrl.locale,
14+
})
15+
: NextResponse.next()
16+
17+
response.headers.set('x-test-used-middleware', 'true')
18+
19+
return response
20+
}
21+
22+
// matcher copied from example in https://nextjs.org/docs/pages/building-your-application/routing/middleware#matcher
23+
export const config = {
24+
matcher: [
25+
/*
26+
* Match all request paths except for the ones starting with:
27+
* - api (API routes)
28+
* - _next/static (static files)
29+
* - _next/image (image optimization files)
30+
* - favicon.ico, sitemap.xml, robots.txt (metadata files)
31+
*/
32+
'/((?!api|_next/static|_next/image|favicon.ico|sitemap.xml|robots.txt).*)',
33+
],
34+
}

‎tests/fixtures/middleware-i18n-excluded-paths/next-env.d.ts

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/// <reference types="next" />
2+
/// <reference types="next/image-types/global" />
3+
4+
// NOTE: This file should not be edited
5+
// see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.

‎tests/fixtures/middleware-i18n-excluded-paths/next.config.js

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
module.exports = {
2+
output: 'standalone',
3+
eslint: {
4+
ignoreDuringBuilds: true,
5+
},
6+
i18n: {
7+
locales: ['en', 'fr'],
8+
defaultLocale: 'en',
9+
},
10+
}

‎tests/fixtures/middleware-i18n-excluded-paths/package.json

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"name": "middleware-i18n-excluded-paths",
3+
"version": "0.1.0",
4+
"private": true,
5+
"scripts": {
6+
"postinstall": "next build",
7+
"dev": "next dev",
8+
"build": "next build"
9+
},
10+
"dependencies": {
11+
"next": "latest",
12+
"react": "18.2.0",
13+
"react-dom": "18.2.0"
14+
},
15+
"devDependencies": {
16+
"@types/node": "^17.0.12",
17+
"@types/react": "18.2.47",
18+
"typescript": "^5.2.2"
19+
}
20+
}

‎tests/fixtures/middleware-i18n-excluded-paths/pages/[[...catchall]].tsx

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import type { GetStaticPaths, GetStaticProps } from 'next'
2+
3+
export default function CatchAll({ params, locale }) {
4+
return <pre>{JSON.stringify({ params, locale }, null, 2)}</pre>
5+
}
6+
7+
export const getStaticPaths: GetStaticPaths = () => {
8+
return {
9+
paths: [],
10+
fallback: 'blocking',
11+
}
12+
}
13+
14+
export const getStaticProps: GetStaticProps = ({ params, locale }) => {
15+
return {
16+
props: {
17+
params,
18+
locale,
19+
},
20+
}
21+
}

‎tests/fixtures/middleware-i18n-excluded-paths/pages/api/[[...catchall]].ts

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import type { NextApiRequest, NextApiResponse } from 'next'
2+
3+
type ResponseData = {
4+
params: {
5+
catchall?: string[]
6+
}
7+
}
8+
9+
export default function handler(req: NextApiRequest, res: NextApiResponse<ResponseData>) {
10+
res.status(200).json({ params: req.query })
11+
}

‎tests/fixtures/middleware-i18n-excluded-paths/tsconfig.json

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"compilerOptions": {
3+
"target": "ES2017",
4+
"lib": ["dom", "dom.iterable", "esnext"],
5+
"allowJs": true,
6+
"skipLibCheck": true,
7+
"strict": false,
8+
"noEmit": true,
9+
"incremental": true,
10+
"module": "esnext",
11+
"esModuleInterop": true,
12+
"moduleResolution": "node",
13+
"resolveJsonModule": true,
14+
"isolatedModules": true,
15+
"jsx": "preserve"
16+
},
17+
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
18+
"exclude": ["node_modules"]
19+
}

‎tests/prepare.mjs

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const e2eOnlyFixtures = new Set([
2323
'after',
2424
'cli-before-regional-blobs-support',
2525
'dist-dir',
26+
'middleware-i18n-excluded-paths',
2627
// There is also a bug on Windows on Node.js 18.20.6, that cause build failures on this fixture
2728
// see https://github.com/opennextjs/opennextjs-netlify/actions/runs/13268839161/job/37043172448?pr=2749#step:12:78
2829
'middleware-og',

‎tests/utils/create-e2e-fixture.ts

+1
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ export const fixtureFactories = {
333333
pnpm: () => createE2EFixture('pnpm', { packageManger: 'pnpm' }),
334334
bun: () => createE2EFixture('simple', { packageManger: 'bun' }),
335335
middleware: () => createE2EFixture('middleware'),
336+
middlewareI18nExcludedPaths: () => createE2EFixture('middleware-i18n-excluded-paths'),
336337
middlewareOg: () => createE2EFixture('middleware-og'),
337338
middlewarePages: () => createE2EFixture('middleware-pages'),
338339
pageRouter: () => createE2EFixture('page-router'),

0 commit comments

Comments
 (0)