test

Author: lindsaylevine

helpers/getNextConfig.js

@@ -4,8 +4,8 @@ const { resolve } = require('path')
 
 const moize = require('moize')
 
-// Load next.config.js
-const getNextConfig = async function (failBuild = defaultFailBuild) {
+// cwd argument needed for moize with tests
+const getNextConfig = async function (cwd = process.cwd(), failBuild = defaultFailBuild) {
   // We cannot load `next` at the top-level because we validate whether the
   // site is using `next` inside `onPreBuild`.
   const { PHASE_PRODUCTION_BUILD } = require('next/constants')
@@ -24,4 +24,5 @@ const defaultFailBuild = function (message, { error }) {
   throw new Error(`${message}\n${error.stack}`)
 }
 
+// module.exports = process.env.NODE_ENV === 'test' ? getNextConfig : moizedGetNextConfig
 module.exports = moizedGetNextConfig

index.js

@@ -28,7 +28,7 @@ module.exports = {
       return failBuild('Could not find a package.json for this project')
     }
 
-    const nextConfig = await getNextConfig(utils.failBuild)
+    const nextConfig = await getNextConfig(process.cwd(), utils.failBuild)
     await restoreCache({ cache: utils.cache, distDir: nextConfig.distDir })
 
     if (await doesNotNeedPlugin({ netlifyConfig, packageJson, failBuild })) {
@@ -70,7 +70,7 @@ module.exports = {
       return
     }
 
-    const nextConfig = await getNextConfig(utils.failBuild)
+    const nextConfig = await getNextConfig(process.cwd(), utils.failBuild)
     await saveCache({cache: utils.cache, distDir: nextConfig.distDir })
     copyUnstableIncludedDirs({ nextConfig, functionsDist: FUNCTIONS_DIST })
   },

test/fixtures/dist_dir_next_config/next.config.js

@@ -0,0 +1,4 @@
+module.exports = {
+  target: 'serverless',
+  distDir: 'build',
+}

test/index.js

@@ -159,6 +159,26 @@ describe('preBuild()', () => {
       }),
     ).rejects.toThrow(`Error loading your next.config.js.`)
   })
+
+  test('restores cache with right paths', async () => {
+    await useFixture('dist_dir_next_config')
+
+    let distPath
+    const utils_ = { ...utils, cache: {
+      restore: (x) => distPath = x } }
+    const spy = jest.spyOn(utils_.cache, 'restore')
+
+
+    await plugin.onPreBuild({
+      netlifyConfig,
+      packageJson: DUMMY_PACKAGE_JSON,
+      utils: utils_,
+      constants: { FUNCTIONS_SRC: 'out_functions' },
+    })
+
+    expect(spy).toHaveBeenCalled()
+    expect(distPath).toBe('build/cache')
+  })
 })
 
 describe('onBuild()', () => {
@@ -233,3 +253,30 @@ describe('onBuild()', () => {
     expect(await pathExists(`${resolvedFunctions}/next_api_test/next_api_test.js`)).toBeTruthy()
   })
 })
+
+describe('onPostBuild', () => {
+  test('saves cache with right paths', async () => {
+    await useFixture('dist_dir_next_config')
+
+    let distPath
+    let manifestPath
+    const utils_ = { ...utils, cache: {
+      save: (x, y) => {
+      distPath = x
+      manifestPath = y
+    } } }
+    const spy = jest.spyOn(utils_.cache, 'save')
+
+
+    await plugin.onPostBuild({
+      netlifyConfig,
+      packageJson: DUMMY_PACKAGE_JSON,
+      utils: utils_,
+      constants: { FUNCTIONS_SRC: 'out_functions' },
+    })
+
+    expect(spy).toHaveBeenCalled()
+    expect(distPath).toBe('build/cache')
+    expect(manifestPath.digests[0]).toBe('build/build-manifest.json')
+  })
+})