test: add simple npm monorepo and deploy from workspace directory without --filter (#305)

* test: add simple npm monorepo and deploy from workspace directory without --filter

* test: use empty base and init git repo

* test: use previous cli

* Revert "test: use previous cli"

This reverts commit d5368afb17a1d909f6f9354c10c2da215986cb9a.

* chore: clearer names in create-e2e-fixtures

* chore: upgrade turbo

* test: install monorepo root deps as well with npm

* test: maybe not run turbo in parallel

* test: maybe not run any test in parallel

* chore: more debug information on deployment failures

* revert some debug changes

* Revert "chore: more debug information on deployment failures"

This reverts commit e3cbe529e624b1ba8833892ed8bbf7cf4f57e8f5.

* remove .gitignore from fixture as there is common one

* test: cleanup, remove empty destructuring

* test: install latest cli in smoke test and don't rely on version in runner

Author: pieh

.github/workflows/run-tests.yml

@@ -80,8 +80,12 @@ jobs:
         run: npm ci
       - name: 'Build'
         run: npm run build
-      - name: 'Lint'
-        run: npm run lint
+      - name: 'Netlify Login'
+        env:
+          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
+        run: |
+          npm i -g netlify-cli
+          netlify login
       - name: Compute Fixtures Cache Key
         id: fixture-cache-key
         # Fixtures only need to be rebuilt if anything in the tests/fixtures directory changes,

tests/smoke/deploy.test.ts

@@ -1,5 +1,6 @@
-import { expect, test } from 'vitest'
+import { expect, test, beforeAll } from 'vitest'
 import { Fixture, fixtureFactories } from '../utils/create-e2e-fixture'
+import { execaCommand } from 'execa'
 
 async function smokeTest(createFixture: () => Promise<Fixture>) {
   const fixture = await createFixture()
@@ -14,3 +15,7 @@ async function smokeTest(createFixture: () => Promise<Fixture>) {
 test('yarn@3 monorepo with pnpm linker', async () => {
   await smokeTest(fixtureFactories.yarnMonorepoWithPnpmLinker)
 })
+
+test('npm monorepo deploying from site directory without --filter', async () => {
+  await smokeTest(fixtureFactories.npmMonorepoEmptyBaseNoPackagePath)
+})

tests/smoke/fixtures/yarn-monorepo-with-pnpm-linker/.gitignore renamed to tests/smoke/fixtures/.gitignore

@@ -0,0 +1,7 @@
+[build]
+base = ""
+command = "npm run build"
+publish = "apps/site/.next"
+
+[[plugins]]
+package = "@netlify/plugin-nextjs"

tests/smoke/fixtures/npm-monorepo-empty-base/apps/site/netlify.toml

@@ -0,0 +1,10 @@
+/** @type {import('next').NextConfig} */
+const nextConfig = {
+  output: 'standalone',
+  eslint: {
+    ignoreDuringBuilds: true,
+  },
+  transpilePackages: ['@repo/ui'],
+}
+
+module.exports = nextConfig

tests/smoke/fixtures/npm-monorepo-empty-base/apps/site/next.config.js

@@ -0,0 +1,14 @@
+{
+  "name": "@apps/site",
+  "version": "0.1.0",
+  "private": true,
+  "scripts": {
+    "build": "next build"
+  },
+  "dependencies": {
+    "@packages/ui": "*",
+    "next": "^14.0.3",
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
+  }
+}

tests/smoke/fixtures/npm-monorepo-empty-base/apps/site/package.json

@@ -0,0 +1,17 @@
+import { TestElement } from '@packages/ui/test.jsx'
+
+export default function Home({ ssr }) {
+  return (
+    <main>
+      <TestElement testid="smoke">SSR: {ssr ? 'yes' : 'no'}</TestElement>
+    </main>
+  )
+}
+
+export const getServerSideProps = async () => {
+  return {
+    props: {
+      ssr: true,
+    },
+  }
+}