-
Notifications
You must be signed in to change notification settings - Fork 86
Error: Cannot find module on ISR when using dynamic imports #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@zomars hey! can i see your package.json and netlify.toml if you have one? links to your site's build/deploy logs would also be great! |
Sure @lindsaylevine ! Here's a deployed url of the previous commit: https://app.netlify.com/sites/jobsite-contentful/deploys/607095a7c76a4b00085000e7 And here's the one with revalidate enabled: https://app.netlify.com/sites/jobsite-contentful/deploys/60709a6453e83a0007e5f78d Here's my
And my relevant dependencies in
|
@zomars ahh apologies! for build/deploy logs i meant a url that looks like: https://app.netlify.com/sites/{yoursitename}/deploys/60627d070f34e32724df2f89 i'm pretty sure i know what's going on already though :( related to next's recent webpack change. this was the previous bug netlify/next-on-netlify#121 - notice it's looking one directory up whereas your error is looking two directories up 🤦 . we'll figure it out though! |
@lindsaylevine my bad! I've updated the above urls. Thank you for your time! 🙏 |
@lindsaylevine Is there a known work around I could use? Maybe downgrading webpack? Or disabling ISR altogether in the mean time? |
@zomars i think you could downgrade next to the last major release? |
@lindsaylevine that would be from 10 to 9? |
ahh my bad i should have been more specific! @zomars "major" release wasn't a good answer; in my head i meant "working" release 😅 . the breaking webpack change in next.js went out in https://github.com/vercel/next.js/releases/tag/v10.0.9 so <= 10.0.8 should work for you? |
I encountered the same problem with the new odb build :( https://github.com/Nexum/netlify-plugin-nextjs-odb-dynamic-bug Live Demo |
Awesome @lindsaylevine ! It this available now to deploy? |
@zomars good question! in theory we shouldnt close the issue until its actually deployed/released (vs when it gets merged). this will go out in our next release. i can make sure it goes out by EOD tomorrow :) |
Thanks you for the response! |
@zomars this should be out now in 3.3.0! |
Describe the bug
Using Incremental Static Regeneration seems to be breaking when using dynamic imported components.
To Reproduce
Steps to reproduce the behavior:
getStaticProps
andgetStaticPaths
next/dynamic
revalidate: 1
ingetStaticProps
Expected behavior
It is expected to show the pre-rendered paged, instead I get this error:
Here's the error output:
Versions
The text was updated successfully, but these errors were encountered: