Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to pass nextConfig down from the top level #354

Closed
lindsaylevine opened this issue May 26, 2021 · 0 comments
Closed

Refactor to pass nextConfig down from the top level #354

lindsaylevine opened this issue May 26, 2021 · 0 comments
Labels
priority: high type: chore work needed to keep the product and development running smoothly wontfix This will not be worked on

Comments

@lindsaylevine
Copy link

this issue really began in next 10.0.2 when the framework changed loadConfig to be async. prior to 10.0.2, we had a sync getNextConfig helper that could be imported and called anywhere with ease. we had a huge refactor ahead of the autoinstall release that turned our entire source async, just to accommodate this change. now, after a lot of thinking and hard work from @rayriffy via #178, our hope/plan is to refactor our codebase to pass nextConfig down from the top level, instead of importing everywhere and making everything async.

per @rayriffy's PR and original issue (#115), we should (through this work) support looking for the config file in the publish dir if it doesn't exist at the root. this would support @rayriffy's use case and other monorepo setups.

@lindsaylevine lindsaylevine added type: chore work needed to keep the product and development running smoothly priority: high labels May 26, 2021
@lindsaylevine lindsaylevine added the wontfix This will not be worked on label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: chore work needed to keep the product and development running smoothly wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant