Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches: 0.1.0-theme & for-standard-v0-1 #75

Open
ghost opened this issue Feb 16, 2022 · 2 comments
Open

Branches: 0.1.0-theme & for-standard-v0-1 #75

ghost opened this issue Feb 16, 2022 · 2 comments
Assignees

Comments

@ghost
Copy link

ghost commented Feb 16, 2022

We have both these branches.

Commit openownership/data-standard@6214029 changes which one is used.

I'm not clear what the situation is here:

  • Can we just delete the branch for-standard-v0-1?
  • Is there anything important in for-standard-v0-1 that we need to port to 0.1.0-theme first?

Assigning to @rhiaro as she did the new branch work

@ghost ghost assigned rhiaro Feb 16, 2022
@rhiaro
Copy link
Collaborator

rhiaro commented Feb 16, 2022

That's weird. I remember needing to pin 0.1.0 to a point before which certain changes were made that might have adversely affected the 0.1.0 docs (ie. version upgrades to something that weren't compatible with a different version of python in the rtd config) before I could make the html change we needed for the automatic version warning to show.. but I don't remember seeing or interacting with the for-standard-v0-1 branch. I may have made a bad assumption about what the 0.1.0 docs were pinned to. The 0.1.0-theme branch is definitely ahead of for-standard-v0-1 (by a couple of years) and I'm pretty sure I audited it for any potentially breaking commits when I was choosing the best point to pin it with the update.

@kathryn-ods
Copy link
Collaborator

I was also wondering today whether for-standard-v0-1 and 0.1.0-theme are both needed - if so we might want to protect these branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants