Skip to content

Commit c7d3241

Browse files
authored
Merge pull request #997 from cesarBLG/fix-independent-default
Disable independent brake syncing by default
2 parents 2d03c3f + 0de38ec commit c7d3241

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

Source/Documentation/Manual/physics.rst

+3-7
Original file line numberDiff line numberDiff line change
@@ -2415,9 +2415,9 @@ present for simplicity.
24152415
single: ORTSDPBrakeSynchronization
24162416

24172417
By default, Open Rails will treat remote groups as manned helpers who typically
2418-
would not assist in train brake operations, so only independent brakes will synchronize.
2419-
To enable train brake synchronization, the token ``engine(ORTSDPBrakeSynchronization(``
2420-
should be used. The valid settings for ``ORTSDPBrakeSynchronization`` are as follows:
2418+
would not assist in train brake operations. To enable brake synchronization,
2419+
the token ``engine(ORTSDPBrakeSynchronization(`` should be used.
2420+
The valid settings for ``ORTSDPBrakeSynchronization`` are as follows:
24212421

24222422
- ``"Apply"``: DP units will reduce the brake pipe pressure locally to match the
24232423
equalizing reservoir pressure of the controlling locomotive. (The controlling
@@ -2432,10 +2432,6 @@ should be used. The valid settings for ``ORTSDPBrakeSynchronization`` are as fol
24322432
controlling locomotive, and will automatically bail-off automatic brake
24332433
applications if needed. (The controlling locomotive must also have the
24342434
``"Independent"`` setting.)
2435-
- NOTE: Although ``"Independent"`` is enabled by default,
2436-
if ``ORTSDPBrakeSynchronization`` is present in the .eng
2437-
file but ``"Independent"`` is not specified as an option,
2438-
independent brakes will NOT be synchronized.
24392435

24402436
All settings can be combined as needed, simply place a comma between each setting
24412437
in the string: ``ORTSDPBrakeSynchronization("Apply, Release, Emergency, Independent")``

Source/Orts.Simulation/Simulation/RollingStocks/MSTSLocomotive.cs

+1-3
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ public float OdometerM
448448
public bool DPSyncTrainApplication { get; private set; }
449449
public bool DPSyncTrainRelease { get; private set; }
450450
public bool DPSyncEmergency { get; private set; }
451-
public bool DPSyncIndependent { get; private set; } = true;
451+
public bool DPSyncIndependent { get; private set; }
452452

453453
protected const float DefaultCompressorRestartToMaxSysPressureDiff = 35; // Used to check if difference between these two .eng parameters is correct, and to correct it
454454
protected const float DefaultMaxMainResToCompressorRestartPressureDiff = 10; // Used to check if difference between these two .eng parameters is correct, and to correct it
@@ -1160,8 +1160,6 @@ public override void Parse(string lowercasetoken, STFReader stf)
11601160
DPSyncEmergency = true;
11611161
if (dpSyncModes.Contains("independent"))
11621162
DPSyncIndependent = true;
1163-
else // Independent synchronization is assumed to be enabled unless explicitly not enabled
1164-
DPSyncIndependent = false;
11651163
break;
11661164
case "engine(ortsdynamicblendingoverride": DynamicBrakeBlendingOverride = stf.ReadBoolBlock(false); break;
11671165
case "engine(ortsdynamicblendingforcematch": DynamicBrakeBlendingForceMatch = stf.ReadBoolBlock(false); break;

0 commit comments

Comments
 (0)