Automatic merge of T1.5.1-368-g38888b34f and 10 pull requests

- Pull request #570 at de7a14f: Experimental glTF 2.0 support with PBR lighting
- Pull request #732 at 22f66dc: Improvements for air brakes
- Pull request #751 at 00981a2: Web interface to control cab controls with external hardware
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 0bb067a: Refactored garbage generators
- Pull request #814 at b102c1c: Bug fix for https://bugs.launchpad.net/or/+bug/2013969 Crash after uncoupling player loco of a train with EOT
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #816 at eae646d: Bug fix for https://bugs.launchpad.net/or/+bug/2014992 EOT can't be dismounted after train reversal
- Pull request #817 at 9c17435: weblink updated

Author: openrails-bot

Source/Orts.Simulation/Simulation/LevelCrossing.cs

@@ -108,8 +108,12 @@ void UpdateCrossings(Train train, float elapsedTime)
             // Separate tests are performed for present speed and for possible maximum speed to avoid anomolies if train accelerates.
             // Special test is also done to check on section availability to avoid closure beyond signal at danger.
 
-            foreach (var crossing in TrackCrossingItems.Values.Where(ci => ci.CrossingGroup != null))
+            foreach (var key in TrackCrossingItems.Keys)
             {
+                var crossing = TrackCrossingItems[key];
+                if (crossing?.CrossingGroup == null)
+                    continue;
+
                 var predictedDist = crossing.CrossingGroup.WarningTime * absSpeedMpS;
                 var maxPredictedDist = crossing.CrossingGroup.WarningTime * (maxSpeedMpS - absSpeedMpS) / 2; // added distance if train accelerates to maxspeed
                 var minimumDist = crossing.CrossingGroup.MinimumDistance;
@@ -299,11 +303,15 @@ void UpdateCrossings(Train train, float elapsedTime)
         public LevelCrossingItem SearchNearLevelCrossing(Train train, float reqDist, bool trainForwards, out float frontDist)
         {
             LevelCrossingItem roadItem = LevelCrossingItem.None;
-           frontDist = -1;
+            frontDist = -1;
             Traveller traveller = trainForwards ? train.FrontTDBTraveller :
                 new Traveller(train.RearTDBTraveller, Traveller.TravellerDirection.Backward);
-            foreach (var crossing in TrackCrossingItems.Values.Where(ci => ci.CrossingGroup != null))
+            foreach (var key in TrackCrossingItems.Keys)
             {
+                var crossing = TrackCrossingItems[key];
+                if (crossing?.CrossingGroup == null)
+                    continue;
+
                 if (crossing.Trains.Contains(train))
                 {
                     frontDist = crossing.DistanceTo(traveller, reqDist);
@@ -445,14 +453,10 @@ public bool HasTrain
         {
             get
             {
-                bool trains = Items.Any(i => i.Trains.Count > 0);
-                bool staticconsists = Items.Any(i => i.StaticConsists.Count > 0);
-                if (trains && staticconsists)
-                    return true;
-                else if (trains || staticconsists)
-                    return true;
-                else
-                    return false;
+                foreach (var item in Items)
+                    if (item.Trains.Count > 0 || item.StaticConsists.Count > 0)
+                        return true;
+                return false;
             }
         }
     }

Source/RunActivity/Viewer3D/RoadCars.cs

@@ -255,13 +255,13 @@ public void Update(ElapsedTime elapsedTime)
             }
 
             // Calculate all the distances to items we need to stop at (level crossings, other cars).
-            var stopDistances = new List<float>();
+            var stopDistance = float.MaxValue;
             for (var crossing = NextCrossingIndex; crossing < crossings.Count; crossing++)
             {
                 if (crossings[crossing].Item.CrossingGroup != null && crossings[crossing].Item.CrossingGroup.HasTrain)
                 {
                     // TODO: Stopping distance for level crossings!
-                    stopDistances.Add(crossings[crossing].Distance - RoadCarSpawner.StopDistance);
+                    stopDistance = Math.Min(stopDistance, crossings[crossing].Distance - RoadCarSpawner.StopDistance);
                     break;
                 }
             }
@@ -271,13 +271,13 @@ public void Update(ElapsedTime elapsedTime)
             if (spawnerIndex > 0)
             {
                 if (!cars[spawnerIndex - 1].CarriesCamera)
-                    stopDistances.Add(cars[spawnerIndex - 1].Travelled - cars[spawnerIndex - 1].Length / 2);
+                    stopDistance = Math.Min(stopDistance, cars[spawnerIndex - 1].Travelled - cars[spawnerIndex - 1].Length / 2);
                 else
-                    stopDistances.Add(cars[spawnerIndex - 1].Travelled - cars[spawnerIndex - 1].Length * 0.65f - 4 - cars[spawnerIndex - 1].Speed * 0.5f);
-                }
+                    stopDistance = Math.Min(stopDistance, cars[spawnerIndex - 1].Travelled - cars[spawnerIndex - 1].Length * 0.65f - 4 - cars[spawnerIndex - 1].Speed * 0.5f);
+            }
 
             // Calculate whether we're too close to the minimum stopping distance (and need to slow down) or going too slowly (and need to speed up).
-            var stopDistance = stopDistances.Count > 0 ? stopDistances.Min() - Travelled - Length / 2 : float.MaxValue;
+            stopDistance = stopDistance - Travelled - Length / 2;
             var slowingDistance = BrakingFactor * Length;
             if (stopDistance < slowingDistance)
                 Speed = SpeedMax * (float)Math.Sin((Math.PI / 2) * (stopDistance / slowingDistance));