Reduce allocations in InputSettings

pzgulyas · pzgulyas · commit a23bd5c20888 · 2023-04-02T08:30:21.000+02:00
diff --git a/Source/ORTS.Settings/InputSettings.cs b/Source/ORTS.Settings/InputSettings.cs
@@ -67,6 +67,7 @@ public class InputSettings : SettingsBase
 
         public static readonly UserCommandInput[] DefaultCommands = new UserCommandInput[Enum.GetNames(typeof(UserCommand)).Length];
         public readonly UserCommandInput[] Commands = new UserCommandInput[Enum.GetNames(typeof(UserCommand)).Length];
+        static readonly UserCommand[] UserCommandValues = (UserCommand[])Enum.GetValues(typeof(UserCommand));
 
         static InputSettings()
         {
@@ -91,7 +92,7 @@ UserCommand GetCommand(string name)
 
         UserCommand[] GetCommands()
         {
-            return (UserCommand[])Enum.GetValues(typeof(UserCommand));
+            return UserCommandValues;
         }
 
         public override object GetDefaultValue(string name)

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ public class InputSettings : SettingsBase`
`67`	`67`
`68`	`68`	`public static readonly UserCommandInput[] DefaultCommands = new UserCommandInput[Enum.GetNames(typeof(UserCommand)).Length];`
`69`	`69`	`public readonly UserCommandInput[] Commands = new UserCommandInput[Enum.GetNames(typeof(UserCommand)).Length];`
	`70`	`+ static readonly UserCommand[] UserCommandValues = (UserCommand[])Enum.GetValues(typeof(UserCommand));`
`70`	`71`
`71`	`72`	`static InputSettings()`
`72`	`73`	`{`
`@@ -91,7 +92,7 @@ UserCommand GetCommand(string name)`
`91`	`92`
`92`	`93`	`UserCommand[] GetCommands()`
`93`	`94`	`{`
`94`		`- return (UserCommand[])Enum.GetValues(typeof(UserCommand));`
	`95`	`+ return UserCommandValues;`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`public override object GetDefaultValue(string name)`