-
Notifications
You must be signed in to change notification settings - Fork 535
add pcre build support for alpine & alpine-fat #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We install PCRE ourselves as is needed for the OpenResty build, but maybe we need to do what agentzh refers to here. I will research it further. |
+1 |
@vkill Thanks for the PR. There's also the Nginx compile lines in that link I have above... I'll pow wow with the OpenResty packagers this week to nail down the exact incantations needed. I'm worried that what you have in the PR fixes one thing but doesn't fix others. But I also wonder if your PR also fixes #22, which would be great. I also want to fix all the build-from-source images in one swoop, so will expand it to that. |
Hi @neomantra , #22 was fixed. the The nginx.conf
The result
The ldd result
|
@vkill @chrisLeeTW I've just pushed a modified version of the #113 pull request. Please check it out and let me know if it works for you. I'm adding one more change to this release and then will tag it. Thanks for the testing and the direction for fixing this issue. @vkill I'm going to close your PR once this is released but if you want to be in the AUTHORS file, give me the name+email you want in there (or no email is fine too). Once the automated build is done, these will be at the simple |
@neomantra It works for me, and I was built the new image for apisix, it also works. |
Great, I just tagged |
Hello,
I've faced the same problem for this issue (openresty/lua-resty-core#258) with alpine & alpine-fat.
It's looks like there no pcre support during the compilation.
May I know that is intended behavior or just some thing missing before ?
Thanks.
The text was updated successfully, but these errors were encountered: