Skip to content

Commit df4033d

Browse files
authored
travis-ci: bumped the NGINX core to 1.19.2. (#1793)
1 parent 0bccfb3 commit df4033d

7 files changed

+63
-12
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@ env:
4848
- TEST_NGINX_SLEEP=0.006
4949
jobs:
5050
- NGINX_VERSION=1.17.8 OPENSSL_VER=1.0.2u OPENSSL_PATCH_VER=1.0.2h
51-
- NGINX_VERSION=1.17.8 OPENSSL_VER=1.1.0l OPENSSL_PATCH_VER=1.1.0d
52-
- NGINX_VERSION=1.17.8 OPENSSL_VER=1.1.1g OPENSSL_PATCH_VER=1.1.1f
51+
- NGINX_VERSION=1.19.3 OPENSSL_VER=1.0.2u OPENSSL_PATCH_VER=1.0.2h
52+
- NGINX_VERSION=1.19.3 OPENSSL_VER=1.1.0l OPENSSL_PATCH_VER=1.1.0d
53+
- NGINX_VERSION=1.19.3 OPENSSL_VER=1.1.1g OPENSSL_PATCH_VER=1.1.1f
5354

5455
services:
5556
- memcached

src/ngx_http_lua_ssl_certby.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,9 @@ ngx_http_lua_ssl_cert_handler(ngx_ssl_conn_t *ssl_conn, void *data)
215215

216216
dd("first time");
217217

218+
#if (nginx_version < 1017009)
218219
ngx_reusable_connection(c, 0);
220+
#endif
219221

220222
hc = c->data;
221223

src/ngx_http_lua_ssl_session_fetchby.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,9 @@ ngx_http_lua_ssl_sess_fetch_handler(ngx_ssl_conn_t *ssl_conn,
237237

238238
dd("first time");
239239

240+
#if (nginx_version < 1017009)
240241
ngx_reusable_connection(c, 0);
242+
#endif
241243

242244
hc = c->data;
243245

t/124-init-worker.t

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,10 @@ lua close the global Lua VM \2
795795
lua close the global Lua VM \3 in the cache helper process \d+
796796
lua close the global Lua VM \3
797797
lua close the global Lua VM \3 in the cache helper process \d+
798+
|lua close the global Lua VM ([0-9A-F]+)
799+
lua close the global Lua VM \4 in the cache helper process \d+
800+
lua close the global Lua VM \4 in the cache helper process \d+
801+
lua close the global Lua VM \4
798802
)(?:lua close the global Lua VM [0-9A-F]+
799803
)*\z/
800804
--- no_error_log

t/129-ssl-socket.t

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,7 @@ $::DSTRootCertificate"
772772
GET /t
773773
--- response_body eval
774774
qr{connected: 1
775-
failed to do SSL handshake: (22: certificate chain too long|20: unable to get local issuer certificate)
775+
failed to do SSL handshake: (22: certificate chain too long|20: unable to get local issuer certificate|21: unable to verify the first certificate)
776776
failed to send http request: closed
777777
}
778778

@@ -781,7 +781,7 @@ failed to send http request: closed
781781
--- grep_error_log_out
782782
--- error_log eval
783783
['lua ssl server name: "openresty.org"',
784-
qr/lua ssl certificate verify error: \((22: certificate chain too long|20: unable to get local issuer certificate)\)/]
784+
qr/lua ssl certificate verify error: \((22: certificate chain too long|20: unable to get local issuer certificate|21: unable to verify the first certificate)\)/]
785785
--- no_error_log
786786
SSL reused session
787787
[alert]
@@ -852,7 +852,7 @@ $::DSTRootCertificate"
852852
GET /t
853853
--- response_body eval
854854
qr/connected: 1
855-
failed to do SSL handshake: (22: certificate chain too long|20: unable to get local issuer certificate)
855+
failed to do SSL handshake: (22: certificate chain too long|20: unable to get local issuer certificate|21: unable to verify the first certificate)
856856
failed to send http request: closed
857857
/
858858

@@ -1938,10 +1938,18 @@ SSL reused session
19381938
19391939
--- request
19401940
GET /t
1941-
--- response_body
1942-
connected: 1
1941+
--- response_body eval
1942+
# Since nginx version 1.19.1, invalidity date is considerd a non-critical CRL
1943+
# entry extension, in other words, revoke still works even if CRL has expired.
1944+
$Test::Nginx::Util::NginxVersion >= 1.019001 ?
1945+
1946+
"connected: 1
1947+
failed to do SSL handshake: 23: certificate revoked
1948+
failed to send http request: closed\n" :
1949+
1950+
"connected: 1
19431951
failed to do SSL handshake: 12: CRL has expired
1944-
failed to send http request: closed
1952+
failed to send http request: closed\n";
19451953
19461954
--- user_files eval
19471955
">>> test.key

t/139-ssl-cert-by.t

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,16 @@ lua ssl server name: "test.com"
119119
[alert]
120120
--- grep_error_log eval: qr/ssl_certificate_by_lua:.*?,|\bssl cert: connection reusable: \d+|\breusable connection: \d+/
121121
--- grep_error_log_out eval
122-
qr/reusable connection: 1
122+
# Since nginx version 1.17.9, nginx call ngx_reusable_connection(c, 0)
123+
# before call ssl callback function
124+
$Test::Nginx::Util::NginxVersion >= 1.017009 ?
125+
qr/reusable connection: 0
126+
ssl cert: connection reusable: 0
127+
ssl_certificate_by_lua:1: ssl cert by lua is running!,/
128+
: qr /reusable connection: 1
123129
ssl cert: connection reusable: 1
124130
reusable connection: 0
125-
ssl_certificate_by_lua:1: ssl cert by lua is running!,
126-
/
131+
ssl_certificate_by_lua:1: ssl cert by lua is running!,/
127132
128133
129134

t/143-ssl-session-fetch.t

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,21 @@ close: 1 nil
8686
--- grep_error_log eval: qr/ssl_session_fetch_by_lua_block:.*?,|\bssl session fetch: connection reusable: \d+|\breusable connection: \d+/
8787
8888
--- grep_error_log_out eval
89+
# Since nginx version 1.17.9, nginx call ngx_reusable_connection(c, 0)
90+
# before call ssl callback function
91+
$Test::Nginx::Util::NginxVersion >= 1.017009 ?
92+
[
93+
qr/\A(?:reusable connection: [01]\n)+\z/s,
94+
qr/^reusable connection: 0
95+
ssl session fetch: connection reusable: 0
96+
ssl_session_fetch_by_lua_block:1: ssl fetch sess by lua is running!,
97+
/m,
98+
qr/^reusable connection: 0
99+
ssl session fetch: connection reusable: 0
100+
ssl_session_fetch_by_lua_block:1: ssl fetch sess by lua is running!,
101+
/m,
102+
]
103+
:
89104
[
90105
qr/\A(?:reusable connection: [01]\n)+\z/s,
91106
qr/^reusable connection: 1
@@ -99,7 +114,6 @@ reusable connection: 0
99114
ssl_session_fetch_by_lua_block:1: ssl fetch sess by lua is running!,
100115
/m,
101116
]
102-
103117
--- no_error_log
104118
[error]
105119
[alert]
@@ -1336,6 +1350,21 @@ ssl handshake: userdata
13361350
close: 1 nil
13371351
--- grep_error_log eval: qr/ssl_session_fetch_by_lua_block:.*?,|\bssl session fetch: connection reusable: \d+|\breusable connection: \d+/
13381352
--- grep_error_log_out eval
1353+
# Since nginx version 1.17.9, nginx call ngx_reusable_connection(c, 0)
1354+
# before call ssl callback function
1355+
$Test::Nginx::Util::NginxVersion >= 1.017009 ?
1356+
[
1357+
qr/\A(?:reusable connection: [01]\n)+\z/s,
1358+
qr/^reusable connection: 0
1359+
ssl session fetch: connection reusable: 0
1360+
ssl_session_fetch_by_lua_block:1: ssl_session_fetch_by_lua\* is running!,
1361+
/m,
1362+
qr/^reusable connection: 0
1363+
ssl session fetch: connection reusable: 0
1364+
ssl_session_fetch_by_lua_block:1: ssl_session_fetch_by_lua\* is running!,
1365+
/m,
1366+
]
1367+
:
13391368
[
13401369
qr/\A(?:reusable connection: [01]\n)+\z/s,
13411370
qr/^reusable connection: 1

0 commit comments

Comments
 (0)