Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EOL package async-cache used in Opensearch-dashboards #5689

Open
aggarwalShivani opened this issue Jan 16, 2024 · 2 comments
Open

[BUG] EOL package async-cache used in Opensearch-dashboards #5689

aggarwalShivani opened this issue Jan 16, 2024 · 2 comments
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@aggarwalShivani
Copy link

Describe the bug
EOL package is being shipped in Opensearch-dashboards. Please find details below:

Th npm package async-cache had reached its EOL and was last published 8 years ago. It is recommended to be replaced by package like lru-cache.
Opensearch dashboards depends on a node-module elastic-apm-node@^3.43.0.

Version 3.x of elastic-apm-node depended on async-cache package. (See here)
From version 4.x of elastic-apm-node, fix is available as it uses lru-cache instead and not async-cache ( See here)

Expected behavior
Opensearch-dashboards to not bundle dependencies/libraries that have reached EOL and aren't supported anymore.

Dashboards Version: 3.0.0 (main branch of the project)

Ask:
To solve this, it would need a major version upgrade of elastic-apm-node to 4.x in dashboards.
Q1: Is this version upgrade already planned?
Q2: Is it feasible to do this version upgrade now? Are there any risks associated or any architectural level changes needed with usage of this package?

Request feedback on the issue and mitigation for EOL issue.
I would be happy to raise a PR if needed.

@aggarwalShivani aggarwalShivani added bug Something isn't working untriaged labels Jan 16, 2024
@kavilla kavilla added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. and removed bug Something isn't working untriaged labels Feb 20, 2024
@kavilla
Copy link
Member

kavilla commented Feb 20, 2024

@AMoo-Miki to comment on this

@AMoo-Miki AMoo-Miki removed their assignment May 1, 2024
@AMoo-Miki
Copy link
Collaborator

I see no licensing problem with using [email protected] with is distributed with 2-clause BSD.

Is this version upgrade already planned?
Is it feasible to do this version upgrade now?

We examine new packages all the time and will surely look into this too.

Are there any risks associated or any architectural level changes needed with usage of this package?

Their changelog indicates a lot of breaking changes. We would only know after an initial examination of the API changes across the versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

3 participants