Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] add use case cards when workspace is disabled, refine the style of recent_work in the home page. #7967

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Sep 3, 2024

Description

This pr can be divided as 2 parts:

  1. add use case cards when workspace is disabled
  2. refine the style of recent_work in the home page, fix the line break issue that occurs when the screen becomes excessively large.

Screenshot

  1. add use case cards when workspace is disabled
Screenshot 2024-09-03 at 13 05 23
  1. fix the line break issue that occurs when the screen becomes excessively large
    before:
Screenshot 2024-09-03 at 13 08 39

now:
Screenshot 2024-09-03 at 13 07 15

Changelog

  • feat: add use case cards when workspace is disabled, refine the style of recent_work in the home page.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Sep 3, 2024
@Qxisylolo Qxisylolo changed the title [WorkSpace] add use case cards when workspace is disabled, refine the style of recent_work in the home page. [Workspace] add use case cards when workspace is disabled, refine the style of recent_work in the home page. Sep 3, 2024
@Qxisylolo Qxisylolo force-pushed the feat/add-use-case-cards-when-workspace-is-disabled branch from 1b5f0da to 6ab8250 Compare September 3, 2024 09:30
Signed-off-by: Qxisylolo <[email protected]>
@ruanyl
Copy link
Member

ruanyl commented Sep 3, 2024

Is this PR ready to review? Also could you please resolve the conflicts?

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo Qxisylolo force-pushed the feat/add-use-case-cards-when-workspace-is-disabled branch from c38c564 to 37ae214 Compare September 3, 2024 10:12
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.53%. Comparing base (a7024e6) to head (f4a2eac).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
...rc/plugins/home/public/application/home_render.tsx 83.33% 0 Missing and 1 partial ⚠️
...nagement/public/management_section/recent_work.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7967      +/-   ##
==========================================
- Coverage   61.01%   60.53%   -0.49%     
==========================================
  Files        3688     3729      +41     
  Lines       87221    88309    +1088     
  Branches    13417    13664     +247     
==========================================
+ Hits        53219    53454     +235     
- Misses      30775    31600     +825     
- Partials     3227     3255      +28     
Flag Coverage Δ
Linux_1 28.72% <7.14%> (-0.63%) ⬇️
Linux_2 56.24% <ø> (-0.01%) ⬇️
Linux_3 37.40% <7.14%> (-0.39%) ⬇️
Linux_4 29.62% <85.71%> (+0.01%) ⬆️
Windows_1 28.73% <7.14%> (-0.63%) ⬇️
Windows_2 56.20% <ø> (-0.01%) ⬇️
Windows_3 37.40% <7.14%> (?)
Windows_4 29.62% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
@SuZhou-Joe
Copy link
Member

Run cypress tests (osd:ciGroup6) should be irrelevant to the code changes.

@SuZhou-Joe SuZhou-Joe merged commit a4470a5 into opensearch-project:main Sep 5, 2024
71 of 73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
… style of recent_work in the home page. (#7967)

* 04-fix-conflication

Signed-off-by: Qxisylolo <[email protected]>

* 02-add-icon

Signed-off-by: Qxisylolo <[email protected]>

* 02-add cards and resolve recent cards

Signed-off-by: Qxisylolo <[email protected]>

* 04-fix-bug

Signed-off-by: Qxisylolo <[email protected]>

* 04-fix-conflication

Signed-off-by: Qxisylolo <[email protected]>

* 05-add-tests

Signed-off-by: Qxisylolo <[email protected]>

* 05-add-tests-1

Signed-off-by: Qxisylolo <[email protected]>

* 06-enable-navigate-to-overview-page

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
(cherry picked from commit a4470a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 5, 2024
… style of recent_work in the home page. (#7967) (#8016)

* 04-fix-conflication



* 02-add-icon



* 02-add cards and resolve recent cards



* 04-fix-bug



* 04-fix-conflication



* 05-add-tests



* 05-add-tests-1



* 06-enable-navigate-to-overview-page



---------


(cherry picked from commit a4470a5)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
… style of recent_work in the home page. (#7967) (#8016)

* 04-fix-conflication

* 02-add-icon

* 02-add cards and resolve recent cards

* 04-fix-bug

* 04-fix-conflication

* 05-add-tests

* 05-add-tests-1

* 06-enable-navigate-to-overview-page

---------

(cherry picked from commit a4470a5)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c47faf2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
… style of recent_work in the home page. (#7967) (#8016) (#8040)

* 04-fix-conflication

* 02-add-icon

* 02-add cards and resolve recent cards

* 04-fix-bug

* 04-fix-conflication

* 05-add-tests

* 05-add-tests-1

* 06-enable-navigate-to-overview-page

---------

(cherry picked from commit a4470a5)




(cherry picked from commit c47faf2)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants