[workspace] fix the UI of delete modal in the save objects(assets) page #8237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Sep 19, 2024
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
|
@kgcreative So no matter new home feature is turned on or off, we will use the term |
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/fix_UI_of_Assets_modal
branch
from
df24abf to
dd520c2
Compare
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/fix_UI_of_Assets_modal
branch
from
20f4ba9 to
b6904f1
Compare
SuZhou-Joe
reviewed
Nov 12, 2024
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
previously approved these changes
Nov 12, 2024
ruanyl
previously approved these changes
Dec 18, 2024
Hailong-am
previously approved these changes
Dec 19, 2024
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
dismissed stale reviews from Hailong-am, ruanyl, and SuZhou-Joe
via
1b4bf6f
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/fix_UI_of_Assets_modal
branch
from
e87f9b4 to
abdd509
Compare
ruanyl
approved these changes
Dec 26, 2024
Hailong-am
approved these changes
Dec 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
…ge (#8237) * fix/fix_UI_of_Assets_modal Signed-off-by: Qxisylolo <[email protected]> * correct tests Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #8237 created/updated * disable button Signed-off-by: Qxisylolo <[email protected]> * update test Signed-off-by: Qxisylolo <[email protected]> * fix tests Signed-off-by: Qxisylolo <[email protected]> * update snapshot Signed-off-by: Qxisylolo <[email protected]> * update snapshot Signed-off-by: Qxisylolo <[email protected]> * add snapshot Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit fb9a814) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Dec 31, 2024
…ge (#8237) (#9132) * fix/fix_UI_of_Assets_modal * correct tests * Changeset file for PR #8237 created/updated * disable button * update test * fix tests * update snapshot * update snapshot * add snapshot --------- (cherry picked from commit fb9a814) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the UI of delete modal in the save objects(assets) page by [issue 300-303]
Screenshot
before:
after:
Changelog
Check List
yarn test:jestyarn test:jest_integration