Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd configurations to strengthen OS core security #17107

Merged
merged 10 commits into from
Feb 23, 2025

Conversation

RajatGupta02
Copy link
Contributor

@RajatGupta02 RajatGupta02 commented Jan 24, 2025

Description

Aims to strengthen the OS core security by using a stronger systemd unit configuration. The changes implement a form of sandboxing via systemd, protecting the system from potential vulnerabilities in the core or untrusted code (such as plugins).

Will be working on adding tests as suggested in the RFC: #1687

Related Issues

#16634

Supporting References

#16729
#1687

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 71b2584: SUCCESS

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (8447737) to head (04d2855).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17107      +/-   ##
============================================
- Coverage     72.48%   72.44%   -0.04%     
- Complexity    65637    65664      +27     
============================================
  Files          5303     5303              
  Lines        304793   304793              
  Branches      44202    44202              
============================================
- Hits         220926   220820     -106     
- Misses        65711    65903     +192     
+ Partials      18156    18070      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Jan 24, 2025

@RajatGupta02 If this is targeting 3.0 can you add an entry in the CHANGELOG for 3.0?

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Rajat Gupta <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 6, 2025

❌ Gradle check result for facaca3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 890612e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kumargu
Copy link
Contributor

kumargu commented Feb 12, 2025

@reta, do you think we can merge this while the Integration test PR is being worked on?

@reta
Copy link
Collaborator

reta commented Feb 12, 2025

@reta, do you think we can merge this while the Integration test PR is being worked on?

@kumargu yes, sure, I think we should be good, @RajatGupta02 could you please resolve the conflicts? thank you

@RajatGupta02
Copy link
Contributor Author

@kumargu yes, sure, I think we should be good, @RajatGupta02 could you please resolve the conflicts? thank you

Resolved 👍🏻

Copy link
Contributor

✅ Gradle check result for 5c66a46: SUCCESS

@RajatGupta02
Copy link
Contributor Author

@kumargu yes, sure, I think we should be good, @RajatGupta02 could you please resolve the conflicts? thank you

Resolved 👍🏻

@reta could you please approve the PR if it looks good?

Copy link
Contributor

❌ Gradle check result for fb983cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 95061fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 95061fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@RajatGupta02
Copy link
Contributor Author

@reta could you please start the workflow and merge this?

@reta
Copy link
Collaborator

reta commented Feb 23, 2025

@reta could you please start the workflow and merge this?

@RajatGupta02 you may need to rebase against latest main

Signed-off-by: Rajat Gupta <[email protected]>
@RajatGupta02
Copy link
Contributor Author

@reta could you please start the workflow and merge this?

@RajatGupta02 you may need to rebase against latest main

Done 👍🏻

Copy link
Contributor

✅ Gradle check result for 04d2855: SUCCESS

@reta reta merged commit e7ac072 into opensearch-project:main Feb 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants