Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Improve flat_object field parsing performance by reducing two passes to a single pass #17126

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

bugmakerrrrrr
Copy link
Contributor

@bugmakerrrrrr bugmakerrrrrr commented Jan 26, 2025

Description

backport #16297

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for cfc1aab: SUCCESS

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 78.01418% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (bf42c3e) to head (cfc1aab).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 78.01% 13 Missing and 18 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17126      +/-   ##
============================================
- Coverage     71.96%   71.93%   -0.04%     
- Complexity    65772    65792      +20     
============================================
  Files          5325     5324       -1     
  Lines        306459   306320     -139     
  Branches      44698    44685      -13     
============================================
- Hits         220554   220338     -216     
- Misses        67432    67626     +194     
+ Partials      18473    18356     -117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 841690c into opensearch-project:2.x Jan 27, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants