-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/backport 16818 to 2.x take2 #17142
Backport/backport 16818 to 2.x take2 #17142
Conversation
Introduce template query that holds the content of query which can contain placeholders and can be filled by the variables from PipelineProcessingContext produced by search processors. This allows query rewrite by the search processors. --------- Signed-off-by: Mingshi Liu <[email protected]> Co-authored-by: Michael Froh <[email protected]> (cherry picked from commit 13ab4ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Instead of extracting an interface from QueryRewriteContext, we can keep it as a base class and subclass it for QueryCoordinatorContext. Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
❌ Gradle check result for d7aa359: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d7aa359: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d7aa359: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Froh <[email protected]>
❌ Gradle check result for b5d218f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for b5d218f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17142 +/- ##
============================================
- Coverage 71.98% 71.97% -0.01%
+ Complexity 65854 65834 -20
============================================
Files 5326 5328 +2
Lines 306531 306604 +73
Branches 44712 44719 +7
============================================
+ Hits 220641 220686 +45
- Misses 67469 67478 +9
- Partials 18421 18440 +19 ☔ View full report in Codecov by Sentry. |
Description
This is an attempt to tweak #17105 to maintain API compatibility for the 2.x branch. Instead of extracting an interface, I just subclassed
QueryRewriteContext
.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.