Support sub agg in filter rewrite optimization #17447
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
github-actions
bot
added
Roadmap:Search
|
{"run-benchmark-test": "id_5"} |
|
{"run-benchmark-test": "id_11"} |
Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
force-pushed
the
sub-agg-pr
branch
from
360b293 to
a031b5a
Compare
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2442/ . Final results will be published once the job is completed. |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2443/ . Final results will be published once the job is completed. |
|
❌ Gradle check result for a031b5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| collectableSubAggregators, | ||
| sub | ||
| ); | ||
| if (optimized) throw new CollectionTerminatedException(); |
There was a problem hiding this comment.
why create a separate variable here instead of just calling if (filterRewriteOptimizationContext.tryOptimize(...)) { throw... } ?
| // @Override | ||
| // protected boolean tryPrecomputeAggregationForLeaf(LeafReaderContext ctx) throws IOException { | ||
| // finishLeaf(); // May need to wrap up previous leaf if it could not be precomputed | ||
| // return filterRewriteOptimizationContext.tryOptimize(ctx, this::incrementBucketDocCount, segmentMatchAll(context, ctx)); | ||
| // } |
There was a problem hiding this comment.
I assume this will be removed when this is ready for review. :)
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
Why are we catching a checked exception and rethrowing an unchecked exception here when the method is documented to throw IOException?
Description
[Describe what this change achieves]
Related Issues
Resolves #12602
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.