Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring update of final type settings in updateSettings function (#1… #1307

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

nisgoel-amazon
Copy link
Contributor

…304)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8258ac5) 74.47% compared to head (5acb187) 46.05%.

Files Patch % Lines
...rch/replication/task/index/IndexReplicationTask.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1307       +/-   ##
=============================================
- Coverage     74.47%   46.05%   -28.42%     
+ Complexity     1026      628      -398     
=============================================
  Files           141      141               
  Lines          4783     4783               
  Branches        526      526               
=============================================
- Hits           3562     2203     -1359     
- Misses          877     2308     +1431     
+ Partials        344      272       -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monusingh-1 monusingh-1 merged commit 532a57f into opensearch-project:main Jan 3, 2024
12 of 15 checks passed
@nisgoel-amazon nisgoel-amazon deleted the main-new branch January 3, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants