Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upstream Client dependency package moved #2512

Closed
dbwiddis opened this issue Feb 10, 2025 · 2 comments
Closed

[BUG] Upstream Client dependency package moved #2512

dbwiddis opened this issue Feb 10, 2025 · 2 comments
Labels
bug Something isn't working untriaged

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Feb 10, 2025

What is the bug?

KNN needs to change imports for 3.0.0 breaking changes in opensearch-project/OpenSearch#17272

How can one reproduce the bug?

See failing builds https://github.com/opensearch-project/k-NN/actions?query=branch%3Amain

/Users/runner/work/k-NN/k-NN/src/main/java/org/opensearch/knn/plugin/rest/RestClearCacheHandler.java:11: error: package org.opensearch.client.node does not exist
import org.opensearch.client.node.NodeClient;
                                 ^

What is the expected behavior?

Main branch compiles

What is your host/environment?

Downstream plugin depending on KNN

Do you have any additional context?

s/o.o.client.Client/o.o.transport.client.Client/g
s/o.o.client.node.NodeClient/o.o.transport.client.node.NodeClient/g

@jmazanec15
Copy link
Member

Fixed in #2442 - closing

@peterzhuamazon
Copy link
Member

One more fix: #2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

3 participants