Fix derived source for binary and byte vectors #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
jmazanec15
added
Bug Fixes
For binary and byte vectors, for derived source, we were not formatting them before adding them back to the source. Thus, they were binary strings in the source. This change fixes this formatting to format them as ints before adding back. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
derived-byte-fix
branch
from
63cf35c to
ed8a06e
Compare
navneet1v
reviewed
Feb 18, 2025
| protected Object formatVector(FieldInfo fieldInfo, KNNVectorValues<?> vectorValues) throws IOException { | ||
| Object vectorValue = vectorValues.getVector(); | ||
| // If the vector value is a byte[], we must deserialize | ||
| if (vectorValue instanceof byte[]) { |
There was a problem hiding this comment.
can we use the datatype of the field here, rather than instance of check on byte[].
There was a problem hiding this comment.
We need a byte[] in order to deserialize, so this check is required. In terms of displaying, deserializeStoredVector takes the vectorDataType, so we can be sure that it will format it properly.
navneet1v
reviewed
Feb 18, 2025
Comment on lines
+34
to
+35
| VectorDataType vectorDataType = FieldInfoExtractor.extractVectorDataType(fieldInfo); | ||
| return KNNVectorFieldMapperUtil.deserializeStoredVector(vectorBytesRef, vectorDataType); |
There was a problem hiding this comment.
Can you elaborate why we need to do this? I am trying to understand this like why we need it, since we already have byte[]
There was a problem hiding this comment.
Sure, this is what the IT I added looks like before:
2> java.lang.AssertionError: Docs do not match: 1 expected:<{test_vector=[115, -43, 26, -69, -40, -100, -72, 25, 111, 14, -5, 104, -110, -7, 77, 104]}> but was:<{test_vector=c9Uau9icuBlvDvtokvlNaA==}>
Basically, source is expected to be an int array, but because we are adding a byte array, it gets serialized as a byte string
navneet1v
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For binary and byte vectors, for derived source, we were not formatting them before adding them back to the source. Thus, they were binary strings in the source. This change fixes this formatting to format them as ints before adding back.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.