Remove usage of cluster level setting for circuit breaker #2567
+575
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
added
Refactoring
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
jmazanec15
force-pushed
the
issue-1607
branch
from
2318611 to
3eaf8b3
Compare
Simplification of circuit breaker management. Before, we were periodically updating the circuit breaker cluster setting to have a global circuit breaker. However, this is inconvenient and not actually useful. This change removes that logic and only trips based on node level circuit breaker. For knn stats, in order to fetch the cluster level circuit breaker, a transport call is made to check all of the nodes. This isnt super efficient but its made for stats calls so its not on the critical path. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
issue-1607
branch
from
3eaf8b3 to
6365da6
Compare
jmazanec15
commented
Feb 27, 2025
| } | ||
| } | ||
| }; | ||
| this.threadPool.scheduleWithFixedDelay(runnable, TimeValue.timeValueSeconds(CB_TIME_INTERVAL), ThreadPool.Names.GENERIC); | ||
| threadPool.scheduleWithFixedDelay(runnable, TimeValue.timeValueSeconds(CB_TIME_INTERVAL), ThreadPool.Names.GENERIC); |
There was a problem hiding this comment.
I could go even a step further an move this to the native cache manager to simplfiy things more.
There was a problem hiding this comment.
I made this change - I think its fairly straightforward and completely removes the potential circular dependency.
jmazanec15
commented
Feb 27, 2025
| @Override | ||
| public Boolean get() { | ||
| try { | ||
| KNNCircuitBreakerTrippedResponse knnCircuitBreakerTrippedResponse = client.execute( |
There was a problem hiding this comment.
TODO: This is going to have to somehow be made to be async, which will complicate things.
There was a problem hiding this comment.
I made this change. Its a bit messy - will clean up a bit.
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
commented
Feb 27, 2025
| import java.util.Map; | ||
| import java.util.function.Function; | ||
|
|
||
| public class CircuitBreakerStat extends KNNStat<Boolean> { |
There was a problem hiding this comment.
TODO: In mixed cluster state, this should fall back to reading from the (deprecated) index setting.
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
issue-1607
branch
from
c91a084 to
019429a
Compare
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
issue-1607
branch
from
b910f38 to
df687f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplification of circuit breaker management. Before, we were periodically updating the circuit breaker cluster setting to have a global circuit breaker. However, this is inconvenient and not actually useful.
This change removes that logic and only trips based on node level circuit breaker. For knn stats, in order to fetch the cluster level circuit breaker, a transport call is made to check all of the nodes. This isnt super efficient but its made for stats calls so its not on the critical path.
Overall, this greatly simplfiies the code. However, it does mean that the cluster setting "knn.circuit_breaker.triggered" will no longer have an effect. But, I think for 3.0 this is okay. For users interested in this info, they can get it from the stats API.
Still fixing up tests pending, but I wanted to get opinions early on the change before investing that time to fix.
Related Issues
Resolves #1607
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.