Replace cdk-ec2-key-pair with CfnKeyPair construct to generate ec2 key pair #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
…y pair Signed-off-by: Rishabh Singh <[email protected]>
peterzhuamazon
approved these changes
Feb 19, 2024
| @@ -53,46 +53,48 @@ OpenSearch Continuous Integration is an open source CI system for OpenSearch and | |||
|
|
|||
| ### Dev Deployment | |||
| 1. Setup your local machine to credentials to deploy to the AWS Account | |||
| 1. Deploy the bootstrap stack by running the following command that sets up required resources to create the stacks. [More info](https://docs.aws.amazon.com/cdk/latest/guide/bootstrapping.html) | |||
| 2. Deploy the bootstrap stack by running the following command that sets up required resources to create the stacks. [More info](https://docs.aws.amazon.com/cdk/latest/guide/bootstrapping.html) | |||
There was a problem hiding this comment.
You can keep these 1/1/1 as they will render as 1/2/3 😄
gaiksaya
reviewed
Feb 20, 2024
| secretName: 'jenkins-agent-node-key-pair', | ||
| description: 'ssh key for jenkins main node to connect to agent nodes', | ||
| }); | ||
| Tags.of(keyPairSecret).add('jenkins:credentials:type', 'sshUserPrivateKey'); |
There was a problem hiding this comment.
So we need this tag for both secret as well as actual ec2 key pair?
There was a problem hiding this comment.
We have to add this tag so that jenkins can read this and use it as ssh key, isnt it?
There was a problem hiding this comment.
This tag is mandatory for the secret but not for the actual key-pair.
Don't see any issue with adding the same tag to key-pair as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace cdk-ec2-key-pair with CfnKeyPair construct to generate ec2 key pair.
aws-cdk-libprovidesCfnKeyPairconstruct to generate ec2 key-pairs. The private key is saved to AWS Systems Manager Parameter Store, using a parameter with the following name: /ec2/keypair/{key_pair_id}. See https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.CfnKeyPair.html for more details.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.