-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal Cypress tests for integrations #990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Hailong-am
reviewed
Jan 8, 2024
cypress/integration/plugins/observability-dashboards/7_integrations.spec.js
Outdated
Show resolved
Hide resolved
Hailong-am
approved these changes
Jan 8, 2024
Signed-off-by: Simeon Widdis <[email protected]>
Blocked by #981 |
Signed-off-by: Simeon Widdis <[email protected]>
ruanyl
reviewed
Jan 22, 2024
cypress/integration/plugins/observability-dashboards/7_integrations.spec.js
Show resolved
Hide resolved
cypress/integration/plugins/observability-dashboards/7_integrations.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
ruanyl
approved these changes
Jan 26, 2024
Yep, should be good to go |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Add tests for integrations Signed-off-by: Simeon Widdis <[email protected]> * Add check for test instance page opening Signed-off-by: Simeon Widdis <[email protected]> * Empty commit to re-trigger run Signed-off-by: Simeon Widdis <[email protected]> * Decouple integrations add and search tests Signed-off-by: Simeon Widdis <[email protected]> * Move instance name constant to test Signed-off-by: Simeon Widdis <[email protected]> * Add integrations teardown process Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 98ec499)
Swiddis
added a commit
to Swiddis/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 2, 2024
* Add tests for integrations Signed-off-by: Simeon Widdis <[email protected]> * Add check for test instance page opening Signed-off-by: Simeon Widdis <[email protected]> * Empty commit to re-trigger run Signed-off-by: Simeon Widdis <[email protected]> * Decouple integrations add and search tests Signed-off-by: Simeon Widdis <[email protected]> * Move instance name constant to test Signed-off-by: Simeon Widdis <[email protected]> * Add integrations teardown process Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
added a commit
to Swiddis/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 2, 2024
* Add tests for integrations Signed-off-by: Simeon Widdis <[email protected]> * Add check for test instance page opening Signed-off-by: Simeon Widdis <[email protected]> * Empty commit to re-trigger run Signed-off-by: Simeon Widdis <[email protected]> * Decouple integrations add and search tests Signed-off-by: Simeon Widdis <[email protected]> * Move instance name constant to test Signed-off-by: Simeon Widdis <[email protected]> * Add integrations teardown process Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
added a commit
to Swiddis/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 2, 2024
* Add tests for integrations Signed-off-by: Simeon Widdis <[email protected]> * Add check for test instance page opening Signed-off-by: Simeon Widdis <[email protected]> * Empty commit to re-trigger run Signed-off-by: Simeon Widdis <[email protected]> * Decouple integrations add and search tests Signed-off-by: Simeon Widdis <[email protected]> * Move instance name constant to test Signed-off-by: Simeon Widdis <[email protected]> * Add integrations teardown process Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
ruanyl
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Add tests for integrations * Add check for test instance page opening * Empty commit to re-trigger run * Decouple integrations add and search tests * Move instance name constant to test * Add integrations teardown process --------- Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two Cypress tests for the Integrations plugin, taken from the dashboards-observability repository.
Issues Resolved
Resolves #989
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.