Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Release 2.4.0 #244

Closed
dblock opened this issue Jan 7, 2025 · 10 comments
Closed

[PROPOSAL] Release 2.4.0 #244

dblock opened this issue Jan 7, 2025 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Jan 7, 2025

What/Why

What are you proposing?

I merged #233 which introduced PSR interfaces. Release 2.4.0.

What users have asked for this feature?

Every user of opensearch-php.

What problems are you trying to solve?

Get rid of RingHTTP, use modern PSR interfaces.

Are there any breaking changes to the API

No, and we could use some help testing and fixing anything broken before we do a release.

@dblock dblock pinned this issue Jan 7, 2025
@dblock dblock added enhancement New feature or request and removed untriaged labels Jan 7, 2025
@dblock
Copy link
Member Author

dblock commented Jan 22, 2025

@kimpepper I tested the current version with dblock/opensearch-php-client-demo#1 and it all seems to work fine. Do you know of anything else we need to fix before doing a release? Want to do us the honors? Release process is documented in https://github.com/opensearch-project/opensearch-php/blob/main/RELEASING.md.

@kimpepper
Copy link
Collaborator

Should we do a 2.4.0-alpha1 release first to encourage testing?

@shyim
Copy link
Collaborator

shyim commented Jan 23, 2025

Yes, I can test it on our project if everything still works

@dblock
Copy link
Member Author

dblock commented Jan 30, 2025

@kimpepper What else do you want to get into this release? It's all yours to cut!

@kimpepper
Copy link
Collaborator

I'll be back home next week so can do it then. Would be good to get someone to walk me through it on Slack though!

@dmnlk
Copy link

dmnlk commented Jan 30, 2025

I have tested this version into my project now.
I haven't found any particular issues.

@dblock
Copy link
Member Author

dblock commented Jan 30, 2025

I'll be back home next week so can do it then. Would be good to get someone to walk me through it on Slack though!

Happy to whenever you're back.

@dmnlk
Copy link

dmnlk commented Feb 3, 2025

Our application tests have been successfully completed without any issues.
We have implemented a workaround because the following PR has not been merged yet, but other than that, there are no particular problems.
#273

@kimpepper
Copy link
Collaborator

Our application tests have been successfully completed without any issues. We have implemented a workaround because the following PR has not been merged yet, but other than that, there are no particular problems. #273

Thanks for testing. We'll get #273 in before release.

@dblock
Copy link
Member Author

dblock commented Feb 3, 2025

🚢

@dblock dblock closed this as completed Feb 3, 2025
@dblock dblock unpinned this issue Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants