Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenSearchCon Banners Squished on Mobile #2809

Closed
dtaivpp opened this issue Apr 28, 2024 · 2 comments · Fixed by #3252
Closed

[BUG] OpenSearchCon Banners Squished on Mobile #2809

dtaivpp opened this issue Apr 28, 2024 · 2 comments · Fixed by #3252
Assignees
Labels
bug Something isn't working

Comments

@dtaivpp
Copy link
Collaborator

dtaivpp commented Apr 28, 2024

Describe the bug
When viewing the homepage on mobile the OpenSearchCon banners are squished.

Screenshots
image

Host/Environment (please complete the following information):

  • OS: iOS
  • Browsers: Safari
@dblock
Copy link
Member

dblock commented Jun 24, 2024

I believe the banner is now gone, but need to verify that it doesn't happen to the current banner.

Catch All Triage - 1 2 3 4 5 6

@kolchfa-aws
Copy link
Collaborator

All of the banners that have text/image will be squished on mobile. To remedy the problem, we should overlay the text on the image and keep the image's aspect ratio the same on any screen size. PR #3252 fixes the problem. Also, there is no need now to provide 2 different images for mobile and desktop because the aspect ratio of the image is kept the same.

A couple of things to note:

  • I added a darker color blue button, which we can use on lighter-colored background images. The original bright blue did not provide enough contrast.
  • If a banner has a long heading/a lot of text, the banner text is obscured by the button on mobile screens and there's a vertical scroll bar appearing for the banner. We should keep the heading/text short and test the banner on all screen sizes before updating the text. There are a couple of alternative layouts to avoid this problem, but I think the banner text/heading should be kept short anyway, so it's not worth spending time on addressing this.
  • While testing, I discovered that the "featured blog posts" carousel contains only one blog even though 3 are marked as featured. There are 10 slots for featured blogs so we should add more blogs to the featured list and we should fix the carousel if it doesn't display the blogs properly.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Website Update Project Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants