Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post "A deep dive into faster semantic sparse retrieval in OpenSearch 2.12" #2908

Merged
merged 18 commits into from
Jun 12, 2024

Conversation

zhichao-aws
Copy link
Member

Description

Add blog post A deep dive into faster semantic sparse retrieval in OpenSearch 2.12

Issues Resolved

#2792

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhichao-aws Please see my comments and changes and let me know if you have any questions. Thanks for putting this together!

@pajuric Because this was so rough and not totally ready for editorial review (it looks like others may still be providing feedback), I had to guess at a lot of revisions/articles/etc. and am not confident in the quality of this post, even with my edits committed. I think I was able to improve it quite a bit, but I'm certain there are still errors present throughout. I would strongly recommend that this be reviewed by a technical writer and re-edited by me prior to publication. Thanks!

zhichao-aws and others added 11 commits May 25, 2024 09:30
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
…ieval-in-OS-2.12.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
@zhichao-aws
Copy link
Member Author

Hi @natebower, I just modified the blog post according to the comments.

I had to guess at a lot of revisions/articles/etc. and am not confident in the quality of this post, even with my edits committed. I think I was able to improve it quite a bit, but I'm certain there are still errors present throughout. I would strongly recommend that this be reviewed by a technical writer and re-edited by me prior to publication. Thanks!

The blog post has gone through several turns of reviews and approved by PM and SDM, I believe we won't conduct major changes to the blog content. For the concerns on "quality", could you please help clarify whether the concerns are for the content perspective or other perspectives like wordings, grammars etc?

@natebower
Copy link
Collaborator

Hi @natebower, I just modified the blog post according to the comments.

I had to guess at a lot of revisions/articles/etc. and am not confident in the quality of this post, even with my edits committed. I think I was able to improve it quite a bit, but I'm certain there are still errors present throughout. I would strongly recommend that this be reviewed by a technical writer and re-edited by me prior to publication. Thanks!

The blog post has gone through several turns of reviews and approved by PM and SDM, I believe we won't conduct major changes to the blog content. For the concerns on "quality", could you please help clarify whether the concerns are for the content perspective or other perspectives like wordings, grammars etc?

My understanding is that @kolchfa-aws was initially asked to support this blog post, given that she wrote the documentation for the feature/functionality, so I’d like for her to review this prior to a second editorial review by me to ensure both quality/accuracy of the content and alignment of messaging between the documentation and the blog post. Thanks!

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws Thanks so much for your work on this 😄. Please see my comments and changes and push to @pajuric when complete. Thanks!

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@natebower Thank you for reviewing! I addressed all your comments. @zhichao-aws If you want to read it over one more time, please do. Otherwise, this blog is ready. cc @pajuric

@pajuric pajuric self-assigned this Jun 10, 2024
Signed-off-by: zhichao-aws <[email protected]>
@pajuric
Copy link

pajuric commented Jun 11, 2024

@nateynateynate @krisfreedain - The blog is ready to push live. With Kris and Nate Boot out of office, are you able to help get this live @kolchfa-aws @natebower, please.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit 2e7a973 into opensearch-project:main Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants