Update correlations overview page and flyout #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flyout for the table Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
vikhy-aws
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
Signed-off-by: vikhy-aws <[email protected]>
…raph Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
AWSHurneyt
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Could we add unit tests (or take a fast follow-up item to add unit tests)? Here's an example test
https://github.com/opensearch-project/security-analytics-dashboards-plugin/blob/main/public/pages/Overview/utils/helper.test.ts
We should also take an action item to add cypress (integration) tests.
| const findingsMap = new Map<string, CorrelationFinding>(); | ||
|
|
||
| correlations.forEach((correlation) => { | ||
| const { finding1, finding2 } = correlation; |
There was a problem hiding this comment.
@riysaxen-amzn could you clarify whether there are any circumstances when a finding for a correlation could be null? For example, if a finding history index is deleted, will there be any risk in findings being null?
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
Signed-off-by: vikhy-aws <[email protected]>
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
amsiglan
reviewed
Jan 29, 2025
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
|
Updating the graph to be force directed. Graph too cluttered when there are a lot of nodes. |
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
|
Changed the graph to be force-directed. |
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
amsiglan
reviewed
Jan 30, 2025
|
Cypress tests run locally |
Signed-off-by: vikhy-aws <[email protected]>
AWSHurneyt
approved these changes
Jan 31, 2025
amsiglan
reviewed
Jan 31, 2025
Signed-off-by: vikhy-aws <[email protected]>
amsiglan
approved these changes
Jan 31, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
* feat: add correlations overview page with a chart and table, and new flyout for the table Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update changes to original component Signed-off-by: vikhy-aws <[email protected]> * feat: add resources column to the table Signed-off-by: vikhy-aws <[email protected]> * fix: maintain different state for graph in the flyout than the main graph Signed-off-by: vikhy-aws <[email protected]> * fix: display mitre tactics as a list and add tooltip for the field Signed-off-by: vikhy-aws <[email protected]> * fix: update as per comments on PR Signed-off-by: vikhy-aws <[email protected]> * fix: update as per comments on PR Signed-off-by: vikhy-aws <[email protected]> * fix: move utility function into helpers Signed-off-by: vikhy-aws <[email protected]> * fix: make table as default view, add spinner, and alert name in flyout Signed-off-by: vikhy-aws <[email protected]> * fix: add a different state variable to track updates to table Signed-off-by: vikhy-aws <[email protected]> * fix: add a different state variable to track updates to table * fix: fix a bug that loading spinner is on when there is no data Signed-off-by: vikhy-aws <[email protected]> * fix: fix a bug that loading spinner is on when there is no data Signed-off-by: vikhy-aws <[email protected]> * fix: change graph configurations to make it force-directed Signed-off-by: vikhy-aws <[email protected]> * fix: change graph configurations to make it force-directed Signed-off-by: vikhy-aws <[email protected]> * fix: increase correlations graph panel height Signed-off-by: vikhy-aws <[email protected]> * seperate out table-view into a different file Signed-off-by: vikhy-aws <[email protected]> * update according to comments on PR Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]> (cherry picked from commit f63b2ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
* feat: add correlations overview page with a chart and table, and new flyout for the table Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update changes to original component Signed-off-by: vikhy-aws <[email protected]> * feat: add resources column to the table Signed-off-by: vikhy-aws <[email protected]> * fix: maintain different state for graph in the flyout than the main graph Signed-off-by: vikhy-aws <[email protected]> * fix: display mitre tactics as a list and add tooltip for the field Signed-off-by: vikhy-aws <[email protected]> * fix: update as per comments on PR Signed-off-by: vikhy-aws <[email protected]> * fix: update as per comments on PR Signed-off-by: vikhy-aws <[email protected]> * fix: move utility function into helpers Signed-off-by: vikhy-aws <[email protected]> * fix: make table as default view, add spinner, and alert name in flyout Signed-off-by: vikhy-aws <[email protected]> * fix: add a different state variable to track updates to table Signed-off-by: vikhy-aws <[email protected]> * fix: add a different state variable to track updates to table * fix: fix a bug that loading spinner is on when there is no data Signed-off-by: vikhy-aws <[email protected]> * fix: fix a bug that loading spinner is on when there is no data Signed-off-by: vikhy-aws <[email protected]> * fix: change graph configurations to make it force-directed Signed-off-by: vikhy-aws <[email protected]> * fix: change graph configurations to make it force-directed Signed-off-by: vikhy-aws <[email protected]> * fix: increase correlations graph panel height Signed-off-by: vikhy-aws <[email protected]> * seperate out table-view into a different file Signed-off-by: vikhy-aws <[email protected]> * update according to comments on PR Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]> (cherry picked from commit f63b2ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new table and a bar graph that displays information by aggregating data on correlation rule, adds a toggle button to toggle visualization between the existing network graph and the newly created table. Also adds a new flyout which describes more information about correlated findings.
Screenshots of pages updated
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.