Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Run SAML Multi Auth integration tests in Cypress (#1729) #1749

Merged

Conversation

DarshitChanpura
Copy link
Member

Manual backport was required due to conflicts in cypress-test-saml-e2e.yml between changes introduced in main and the ones already present on 2.x. (Remove this line before merge)

Description

Backports a36ef1f from #1729
(cherry picked from commit a36ef1f)

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…1729)

Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
(cherry picked from commit a36ef1f)
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (898a16f) 66.76% compared to head (ad2f2a0) 66.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1749   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          93       93           
  Lines        2353     2353           
  Branches      311      311           
=======================================
  Hits         1571     1571           
  Misses        705      705           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Jan 23, 2024

Thank you for creating the manual backport @DarshitChanpura !

@cwperks cwperks merged commit 2c2b9ad into opensearch-project:2.x Jan 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants