Skip to content

Commit 9a59494

Browse files
authored
Add ENABLE_VIRTUAL_MEDIA_VIA_EXTERNAL_NETWORK environment variable (#1357)
This new ENABLE_VIRTUAL_MEDIA_VIA_EXTERNAL_NETWORK will be used to pass virtualMediaViaExternalNetwork as true in provisioning configs. virtualMediaViaExternalNetwork, when it is set to true, allows for worker to boot via Virtual Media and contact metal3 over the External Network. With this PR, we will be able to test this functionality in our CI jobs to assure that it is working as expected or not. Moreover, users also can use that environment variable if they want to boot workers via Virtual Media and contact metal3 over the External Network.
1 parent 081b22d commit 9a59494

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

06_create_cluster.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,8 @@ if [[ ! -z "${ENABLE_METALLB}" ]]; then
8383
popd
8484
fi
8585

86+
if [[ ! -z "${ENABLE_VIRTUAL_MEDIA_VIA_EXTERNAL_NETWORK}" ]]; then
87+
oc patch provisioning provisioning-configuration --type merge -p "{\"spec\":{\"virtualMediaViaExternalNetwork\":true}}"
88+
fi
89+
8690
echo "Cluster up, you can interact with it via oc --config ${KUBECONFIG} <command>"

config_example.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,11 @@ set -x
169169
#export SERVICE_SUBNET_V4="172.30.0.0/16"
170170
#export SERVICE_SUBNET_V6="fd02::/112"
171171

172+
# Enable virtualMediaViaExternalNetwork in provisioning
173+
# configuration.
174+
# More info: https://github.com/openshift/cluster-baremetal-operator/blob/master/api/v1alpha1/provisioning_types.go#L163-L171
175+
#export ENABLE_VIRTUAL_MEDIA_VIA_EXTERNAL_NETWORK=true
176+
172177
# Enable testing of custom machine-api-operator-image
173178
#export TEST_CUSTOM_MAO=true
174179

0 commit comments

Comments
 (0)