Skip to content

Commit e7976ab

Browse files
committed
Revert "OCPEDGE-1419 Add ksan-storage extension"
This reverts commit 302b6f0.
1 parent ca35403 commit e7976ab

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

docs/MachineConfig.md

-1
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ RHCOS is a minimal OCP focused OS which provides capabilities common across all
210210
| 4.11 | `usbguard`, `sandboxed-containers`, `kerberos` |
211211
| 4.14 | `usbguard`, `sandboxed-containers`, `kerberos`, `ipsec`, `wasm` |
212212
| 4.17 | `usbguard`, `sandboxed-containers`, `kerberos`, `ipsec`, `wasm` , `sysstat` |
213-
| 4.19 | `usbguard`, `sandboxed-containers`, `kerberos`, `ipsec`, `wasm` , `sysstat` , `ksan-storage` |
214213

215214
Extensions can be installed by creating a MachineConfig object. Extensions can be enabled as both day1 and day2. Check [installer guide](https://github.com/openshift/installer/blob/master/docs/user/customization.md#Enabling-RHCOS-Extensions) to enable extensions during cluster install.
216215

pkg/controller/common/helpers.go

-1
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,6 @@ func SupportedExtensions() map[string][]string {
673673
"kernel-devel": {"kernel-devel", "kernel-headers"},
674674
"sandboxed-containers": {"kata-containers"},
675675
"sysstat": {"sysstat"},
676-
"ksan-storage": {"lvm2-lockd", "sanlock"},
677676
}
678677
}
679678

test/e2e-single-node/sno_mcd_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ func TestExtensions(t *testing.T) {
196196
Config: runtime.RawExtension{
197197
Raw: helpers.MarshalOrDie(ctrlcommon.NewIgnConfig()),
198198
},
199-
Extensions: []string{"wasm", "ipsec", "usbguard", "kernel-devel", "kerberos", "sysstat", "ksan-storage"},
199+
Extensions: []string{"wasm", "ipsec", "usbguard", "kernel-devel", "kerberos", "sysstat"},
200200
},
201201
}
202202

@@ -212,8 +212,8 @@ func TestExtensions(t *testing.T) {
212212
assert.Equal(t, node.Annotations[constants.CurrentMachineConfigAnnotationKey], renderedConfig)
213213
assert.Equal(t, node.Annotations[constants.MachineConfigDaemonStateAnnotationKey], constants.MachineConfigDaemonStateDone)
214214

215-
installedPackages := helpers.ExecCmdOnNode(t, cs, node, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat", "lvm2-lockd", "sanlock")
216-
expectedPackages := []string{"crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat", "lvm2-lockd", "sanlock"}
215+
installedPackages := helpers.ExecCmdOnNode(t, cs, node, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat")
216+
expectedPackages := []string{"crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat"}
217217
for _, v := range expectedPackages {
218218
if !strings.Contains(installedPackages, v) {
219219
t.Fatalf("Node %s doesn't have expected extensions", node.Name)
@@ -237,7 +237,7 @@ func TestExtensions(t *testing.T) {
237237
assert.Equal(t, node.Annotations[constants.CurrentMachineConfigAnnotationKey], oldMasterRenderedConfig)
238238
assert.Equal(t, node.Annotations[constants.MachineConfigDaemonStateAnnotationKey], constants.MachineConfigDaemonStateDone)
239239

240-
installedPackages = helpers.ExecCmdOnNode(t, cs, node, "chroot", "/rootfs", "rpm", "-qa", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat", "lvm2-lockd", "sanlock")
240+
installedPackages = helpers.ExecCmdOnNode(t, cs, node, "chroot", "/rootfs", "rpm", "-qa", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "krb5-workstation", "libkadm5", "sysstat")
241241
for _, v := range expectedPackages {
242242
if strings.Contains(installedPackages, v) {
243243
t.Fatalf("Node %s did not rollback successfully", node.Name)

test/e2e/mcd_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ func TestExtensions(t *testing.T) {
332332
Config: runtime.RawExtension{
333333
Raw: helpers.MarshalOrDie(ctrlcommon.NewIgnConfig()),
334334
},
335-
Extensions: []string{"wasm", "ipsec", "usbguard", "kerberos", "kernel-devel", "sandboxed-containers", "sysstat", "ksan-storage"},
335+
Extensions: []string{"wasm", "ipsec", "usbguard", "kerberos", "kernel-devel", "sandboxed-containers", "sysstat"},
336336
},
337337
}
338338

@@ -357,12 +357,12 @@ func TestExtensions(t *testing.T) {
357357
if isOKD {
358358
// OKD does not support grouped extensions yet, so installing kernel-devel will not also pull in kernel-headers
359359
// "sandboxed-containers" extension is not available on OKD
360-
installedPackages = helpers.ExecCmdOnNode(t, cs, infraNode, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "sysstat", "lvm2-lockd", "sanlock")
360+
installedPackages = helpers.ExecCmdOnNode(t, cs, infraNode, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "sysstat")
361361
// "kerberos" extension is not available on OKD
362362
expectedPackages = []string{"libreswan", "usbguard", "kernel-devel"}
363363
} else {
364-
installedPackages = helpers.ExecCmdOnNode(t, cs, infraNode, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "kata-containers", "krb5-workstation", "libkadm5", "sysstat", "lvm2-lockd", "sanlock")
365-
expectedPackages = []string{"crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "kata-containers", "krb5-workstation", "libkadm5", "sysstat", "lvm2-lockd", "sanlock"}
364+
installedPackages = helpers.ExecCmdOnNode(t, cs, infraNode, "chroot", "/rootfs", "rpm", "-q", "crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "kata-containers", "krb5-workstation", "libkadm5", "sysstat")
365+
expectedPackages = []string{"crun-wasm", "libreswan", "usbguard", "kernel-devel", "kernel-headers", "kata-containers", "krb5-workstation", "libkadm5", "sysstat"}
366366

367367
}
368368
for _, v := range expectedPackages {

0 commit comments

Comments
 (0)