Skip to content

Commit 0632475

Browse files
authored
Merge branch 'main' into test_CK
2 parents 146eba2 + 5b1d21e commit 0632475

File tree

326 files changed

+8048
-1751
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

326 files changed

+8048
-1751
lines changed

.pre-commit-config.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,15 @@ repos:
4545
additional_dependencies:
4646
- netaddr
4747
- jmespath
48+
49+
# Sync test_operator README with defaults/main.yml
50+
- repo: local
51+
hooks:
52+
- id: sync-test-operator-readme
53+
name: Sync test_operator README
54+
entry: python scripts/sync_test_operator_var_readme.py
55+
language: python
56+
files: ^roles/test_operator/defaults/main\.yml$
57+
pass_filenames: false
58+
additional_dependencies:
59+
- PyYAML

CONTRIBUTING.md

Lines changed: 65 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,6 @@ Here is an example, based on a common use-case, on how to use those variables
4545
oc get openstackdataplane -n {{ cifmw_install_yamls_defaults['NAMESPACE'] }}
4646
~~~
4747

48-
## A few words about using Git
49-
50-
Before you make a pull request, make sure that:
51-
52-
* the title of your git commit message begins with the role
53-
name in brackets: `[my_wonderful_role]` or `(my_wonderful_role)`
54-
* the git commit body message is longer than 10 characters and describes
55-
the reason why you added this change
56-
* sign your git commit using the `Signed-Off-By` option by
57-
adding: `--signoff` or `-s` when using the command: `git commit`.
58-
* if you already make a commit, and you want to add `Signed-Off-By`,
59-
use command: `git commit --amend --signoff`
60-
6148
### Documentation
6249

6350
A new role must get proper documentation. Please edit the README.md located in
@@ -99,6 +86,71 @@ role, and re-run `make role_molecule` to re-generate the the jobs and project li
9986

10087
Please add a note in the role README.md for future reference.
10188

89+
## A few words about using Git
90+
91+
Before you make a pull request, make sure that:
92+
93+
* the title of your git commit message begins with the role
94+
name in brackets: `[my_wonderful_role]` or `(my_wonderful_role)`
95+
* the git commit body message is longer than 10 characters and describes
96+
the reason why you added this change
97+
* sign your git commit using the `Signed-Off-By` option by
98+
adding: `--signoff` or `-s` when using the command: `git commit`.
99+
* if you already make a commit, and you want to add `Signed-Off-By`,
100+
use command: `git commit --amend --signoff`
101+
102+
## AI/LLM Assisted Development
103+
104+
When using AI tools for contributions, follow these guidelines to ensure transparency and code quality.
105+
106+
### Attribution Requirements
107+
108+
* **Major AI contribution** (substantial code/logic generation): Use `Co-Authored-By:`
109+
* **Minor AI assistance** (refactoring/optimization): Use `Assisted-By:`
110+
111+
~~~
112+
[role_name] Add EDPM validation logic
113+
114+
Implements connectivity tests and health monitoring for EDPM nodes.
115+
116+
Co-Authored-By: Claude Code <noreply@anthropic.com>
117+
Signed-off-by: Your Name <your.email@example.com>
118+
~~~
119+
120+
~~~
121+
[role_name] Refactor validation error handling
122+
123+
Simplified logic and improved debugging messages.
124+
125+
Assisted-By: Gemini <noreply@google.com>
126+
Signed-off-by: Your Name <your.email@example.com>
127+
~~~
128+
129+
### Code Quality Requirements
130+
131+
Before submitting AI-assisted code:
132+
133+
* Review all generated code for correctness and security
134+
* Ensure compliance with existing project patterns and naming conventions
135+
* Verify no hardcoded credentials or sensitive data exposure
136+
* Test thoroughly, especially edge cases and error scenarios
137+
* Add proper documentation and comments
138+
139+
### Review Process
140+
141+
* Complete thorough self-review before PR submission
142+
* Standard review policy applies (minimum 2 reviewers)
143+
* Security-sensitive code requires additional maintainer review
144+
* Disclose AI assistance scope in PR description
145+
146+
### Security and Best Practices
147+
148+
* Never share sensitive project data with AI tools
149+
* Don't use AI for credential generation or security policy decisions
150+
* Provide relevant project context when prompting AI tools
151+
* Use AI as a starting point, not final solution
152+
* Maintain human oversight throughout development process
153+
102154
## Adding new script
103155

104156
If you want/need to add a new script (python, bash, perl, ...), please provide

OWNERS_ALIASES

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,13 @@ aliases:
2929
- lmiccini
3030
- ccamposr
3131
- eduolivares
32-
- frenzyfriday
3332

3433
dcn-team:
3534
- fultonj
3635
- jokke-ilujo
3736

3837
must-gather-team:
3938
- dprince
40-
- olliewalsh
4139
- gibizer
4240
- fmount
4341
- abays

ci/playbooks/collect-logs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
become: true
178178
ansible.builtin.shell: |
179179
journalctl -u kubelet > kubelet.log
180-
no_log: true
180+
no_log: "{{ cifmw_nolog | default(true) | bool }}"
181181
args:
182182
chdir: "{{ ansible_user_dir }}/zuul-output/logs/"
183183

ci/playbooks/e2e-collect-logs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
become: true
4848
ansible.builtin.shell: |
4949
journalctl -u kubelet > kubelet.log
50-
no_log: true
50+
no_log: "{{ cifmw_nolog | default(true) | bool }}"
5151
args:
5252
chdir: "{{ ansible_user_dir }}/zuul-output/logs/"
5353

ci/playbooks/multinode-customizations.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213

214214
- name: Set insecure registry on crc node
215215
ansible.builtin.include_tasks: tasks/set_crc_insecure_registry.yml
216-
when: content_provider_registry_ip is defined
216+
when: content_provider_registry_ip is defined or cifmw_crc_registry_mirror_content is defined
217217

218218
- hosts: controller
219219
name: "Tweak Controller"

ci/playbooks/tasks/inherit_parent_scenario.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@
2727
- item is exists
2828
ansible.builtin.include_vars:
2929
file: "{{ item }}"
30-
loop: "{{ _file_list }}"
30+
loop: "{{ _file_list | from_yaml }}"

ci/playbooks/tasks/set_crc_insecure_registry.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
---
22
# noqa: schema[playbook]
33
- name: Patch the image.config.openshift.io resource to include insecure registry
4+
when: content_provider_registry_ip is defined
45
ansible.builtin.shell: >-
56
oc patch --type=merge --patch='{
67
"spec": {
@@ -13,6 +14,7 @@
1314
}' image.config.openshift.io/cluster
1415
1516
- name: Patch the image.config.openshift.io resource to allow registries
17+
when: content_provider_registry_ip is defined
1618
ansible.builtin.shell: |
1719
oc patch --type=merge --patch='{
1820
"spec": {
@@ -28,14 +30,24 @@
2830
}
2931
}' image.config.openshift.io/cluster
3032
33+
- name: Add additional allowed registries
34+
when: cifmw_crc_additional_allowed_registries is defined
35+
ansible.builtin.shell: |
36+
oc patch --type=json \
37+
--patch='[{"op": "add", "path": "/spec/registrySources/allowedRegistries/-", "value": "{{ item }}"}]' \
38+
image.config.openshift.io/cluster
39+
loop: "{{ cifmw_crc_additional_allowed_registries }}"
40+
3141
- name: Ensure registries.conf.d exists
3242
become: true
43+
when: cifmw_crc_registry_mirror_content is defined or content_provider_registry_ip is defined
3344
ansible.builtin.file:
3445
path: /etc/containers/registries.conf.d
3546
state: directory
3647

3748
- name: Set Insecure registry for content provider
3849
become: true
50+
when: content_provider_registry_ip is defined
3951
ansible.builtin.blockinfile:
4052
state: present
4153
insertafter: EOF
@@ -49,7 +61,18 @@
4961
mirror-by-digest-only = false
5062
prefix = ""
5163
64+
- name: Set registry mirror override
65+
when: cifmw_crc_registry_mirror_content is defined
66+
become: true
67+
ansible.builtin.blockinfile:
68+
state: present
69+
insertafter: EOF
70+
dest: /etc/containers/registries.conf.d/12-override.conf
71+
create: true
72+
content: "{{ cifmw_crc_registry_mirror_content }}"
73+
5274
- name: Restart crio
75+
when: cifmw_crc_registry_mirror_content is defined or content_provider_registry_ip is defined
5376
become: true
5477
ansible.builtin.service:
5578
name: crio

ci/templates/projects.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
templates:
99
- podified-multinode-edpm-ci-framework-pipeline
1010
- data-plane-adoption-ci-framework-pipeline
11+
- whitebox-neutron-tempest-plugin-podified-pipeline
1112
github-check:
1213
jobs:
1314
- noop

common-requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
ansible-core==2.15.13
22
oauthlib==3.2.2
3-
kubernetes==31.0.0
4-
kubernetes-validate==1.31.0
3+
kubernetes==35.0.0
4+
kubernetes-validate==1.35.0
55
openstacksdk==4.1.0
66
jsonschema==4.23.0
77
pyOpenSSL==24.2.1

0 commit comments

Comments
 (0)