Commit 73709c2
committed
[cifmw_nfs] Fix IPSet hostname lookup regression
PR #3930 added an explicit `ansible.builtin.setup` task before the
`cifmw_nfs` role invocation and changed `import_role` to
`include_role`. Both changes cause `ansible_domain` to resolve
incorrectly in the `_nfs_host` variable:
- The explicit `setup` gathers fresh facts **after** EDPM deployment
has configured the compute's hostname with a domain suffix
(`ctlplane.example.com`), causing the IPSet lookup to use
`compute-0.ctlplane.example.com` instead of `compute-0`.
- `include_role` alters variable scoping so `ansible_domain` no
longer resolves from the play target host's facts.
**Fix:**
- Remove the explicit `setup` task. With `gather_facts: false` and
no manual fact gathering, `ansible_domain` remains undefined. The
`select()` filter in `_nfs_host` drops it, producing the correct
short hostname matching the IPSet name.
- Revert `include_role` back to `import_role` to restore play-level
variable scoping.
Fixes: `component-watcher` and other NFS-based jobs broken after
PR #3930 merged.
Related-Issue: ANVIL-109
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>1 parent b2d59cb commit 73709c2
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | 98 | | |
102 | 99 | | |
103 | 100 | | |
104 | 101 | | |
105 | 102 | | |
106 | 103 | | |
107 | | - | |
| 104 | + | |
108 | 105 | | |
109 | 106 | | |
110 | 107 | | |
| |||
0 commit comments