From fd3b69fbf9e5d0e9cad31b379cdf652793aa05ad Mon Sep 17 00:00:00 2001
From: Dan Prince <dprince@redhat.com>
Date: Mon, 28 Oct 2024 16:15:47 -0400
Subject: [PATCH] Simplify and fix name issue with ToCoreVolume

---
 modules/storage/storage.go | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/modules/storage/storage.go b/modules/storage/storage.go
index a14edabb..641706b5 100644
--- a/modules/storage/storage.go
+++ b/modules/storage/storage.go
@@ -167,17 +167,13 @@ func (s *VolumeSource) ToCoreVolumeSource() (*corev1.VolumeSource, error) {
 
 // ToCoreVolume - convert Volume to corev1.Volume
 func (s *Volume) ToCoreVolume() (*corev1.Volume, error) {
-	coreVolume := &corev1.Volume{}
-
-	coreVolumeBytes, err := json.Marshal(s)
+	volSource, err := s.VolumeSource.ToCoreVolumeSource()
 	if err != nil {
-		return nil, fmt.Errorf("error marshalling Volume: %w", err)
+		return nil, err
 	}
-
-	err = json.Unmarshal(coreVolumeBytes, coreVolume)
-	if err != nil {
-		return nil, fmt.Errorf("error unmarshalling Volume: %w", err)
+	coreVolume := &corev1.Volume{
+		Name:         s.Name,
+		VolumeSource: *volSource,
 	}
-
 	return coreVolume, nil
 }