Skip to content

Commit 921fc71

Browse files
committed
Add rsyslog image defaults
The RELATED_IMAGE_OCTAVIA_RSYSLOG_IMAGE_URL_DEFAULT and related default overrides were missing for the log offloading feature. JIRA: OSPRH-12496
1 parent 575fc03 commit 921fc71

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

api/v1beta1/octavia_types.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ const (
4141
// ApacheImage - default fall-back image for Apache
4242
ApacheContainerImage = "registry.redhat.io/ubi9/httpd-24:latest"
4343

44+
// OctaviaRsyslogContainer image is the fall-back container image for OctaviaRsyslog
45+
RsyslogContainerImage = "quay.io/podified-antelope-centos9/openstack-rsyslog:current-podified"
46+
4447
// Octavia API timeout
4548
APITimeout = 120
4649
)
@@ -369,6 +372,7 @@ func SetupDefaults() {
369372
HealthManagerContainerImageURL: util.GetEnvVar("RELATED_IMAGE_OCTAVIA_HEALTHMANAGER_IMAGE_URL_DEFAULT", OctaviaHealthManagerContainerImage),
370373
WorkerContainerImageURL: util.GetEnvVar("RELATED_IMAGE_OCTAVIA_WORKER_IMAGE_URL_DEFAULT", OctaviaWorkerContainerImage),
371374
ApacheContainerImageURL: util.GetEnvVar("RELATED_IMAGE_OCTAVIA_APACHE_IMAGE_URL_DEFAULT", ApacheContainerImage),
375+
RsyslogContainerImageURL: util.GetEnvVar("RELATED_IMAGE_OCTAVIA_RSYSLOG_IMAGE_URL_DEFAULT", RsyslogContainerImage),
372376
OctaviaAPIRouteTimeout: APITimeout,
373377
// No default for AmphoraImageContainerImageURL
374378
}

api/v1beta1/octavia_webhook.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ type OctaviaDefaults struct {
3838
WorkerContainerImageURL string
3939
ApacheContainerImageURL string
4040
OctaviaAPIRouteTimeout int
41+
RsyslogContainerImageURL string
4142
}
4243

4344
var octaviaDefaults OctaviaDefaults
@@ -86,6 +87,9 @@ func (spec *OctaviaSpec) Default() {
8687
if spec.ApacheContainerImage == "" {
8788
spec.ApacheContainerImage = octaviaDefaults.ApacheContainerImageURL
8889
}
90+
if spec.OctaviaRsyslog.ContainerImage == "" {
91+
spec.OctaviaRsyslog.ContainerImage = octaviaDefaults.RsyslogContainerImageURL
92+
}
8993
}
9094

9195
// Default - set defaults for this Octavia core spec (this version is used by the OpenStackControlplane webhook)

config/default/manager_default_images.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,5 @@ spec:
2121
value: quay.io/podified-antelope-centos9/openstack-octavia-worker:current-podified
2222
- name: RELATED_IMAGE_OCTAVIA_APACHE_IMAGE_URL_DEFAULT
2323
value: registry.redhat.io/ubi9/httpd-24:latest
24+
- name: RELATED_IMAGE_OCTAVIA_RSYSLOG_IMAGE_URL_DEFAULT
25+
value: quay.io/podified-antelope-centos9/openstack-rsyslog:current-podified

tests/kuttl/common/assert_sample_deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,9 @@ commands:
241241
APACHE)
242242
template='{{.spec.apacheContainerImage}}'
243243
;;
244+
RSYSLOG)
245+
template='{{.spec.octaviaRsyslog.containerImage}}'
246+
;;
244247
esac
245248
SERVICE_IMAGE=$(oc get -n $NAMESPACE octavia octavia -o go-template="$template")
246249
if [ "$SERVICE_IMAGE" != "$IMG_FROM_ENV" ]; then

0 commit comments

Comments
 (0)