Fix the nil pointing issue

eshulman2 · eshulman2 · commit 25b0b1d0f4d1 · 2024-11-05T08:55:19.000+02:00
When a workflow is set without ExtraConfigMap in ansible controller the pod won't be able to start because the pointer won't be pointing at nothing. Changed the condition to allow avoiding this issue. Jira: https://issues.redhat.com/browse/OSPRH-11191
diff --git a/pkg/ansibletest/volumes.go b/pkg/ansibletest/volumes.go
@@ -106,7 +106,7 @@ func GetVolumes(
 		volumes = append(volumes, extraVol)
 	}
 
-	if len(instance.Spec.Workflow) > 0 {
+	if len(*instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts) > 0 {
 		for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {
 			extraWorkflowVol := corev1.Volume{
 				Name: vol.Name,
@@ -204,7 +204,7 @@ func GetVolumeMounts(mountCerts bool, instance *testv1beta1.AnsibleTest, externa
 		volumeMounts = append(volumeMounts, extraConfigmapsMounts)
 	}
 
-	if len(instance.Spec.Workflow) > 0 {
+	if len(*instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts) > 0 {
 		for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {
 
 			extraConfigmapsMounts := corev1.VolumeMount{

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func GetVolumes(`
`106`	`106`	`volumes = append(volumes, extraVol)`
`107`	`107`	`}`
`108`	`108`
`109`		`- if len(instance.Spec.Workflow) > 0 {`
	`109`	`+ if len(*instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts) > 0 {`
`110`	`110`	`for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {`
`111`	`111`	`extraWorkflowVol := corev1.Volume{`
`112`	`112`	`Name: vol.Name,`
`@@ -204,7 +204,7 @@ func GetVolumeMounts(mountCerts bool, instance *testv1beta1.AnsibleTest, externa`
`204`	`204`	`volumeMounts = append(volumeMounts, extraConfigmapsMounts)`
`205`	`205`	`}`
`206`	`206`
`207`		`- if len(instance.Spec.Workflow) > 0 {`
	`207`	`+ if len(*instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts) > 0 {`
`208`	`208`	`for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {`
`209`	`209`
`210`	`210`	`extraConfigmapsMounts := corev1.VolumeMount{`