fix(sdk): Updates preferred node to 22 (#408)

- this is the 'active' LTS branch of node
- remove polyfills, possible both due to upgrade and due to removal of streamsaver, event emitter, and other compatibility libraries

Author: dmihalcik-virtru

.github/workflows/build.yaml

@@ -27,7 +27,7 @@ jobs:
           fetch-depth: ${{ !fromJSON(env.do_sonarscan) && 1 || 0 }}
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './lib/package-lock.json'
       - run: npm ci
@@ -67,7 +67,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './cli/package-lock.json'
       - uses: actions/download-artifact@v4
@@ -100,7 +100,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './web-app/package-lock.json'
       - uses: actions/download-artifact@v4
@@ -145,7 +145,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './web-app/package-lock.json'
       - uses: actions/download-artifact@v4
@@ -200,7 +200,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           registry-url: https://npm.pkg.github.com
       - name: Check version number is same between tag, library, and/or release
         id: check-version
@@ -250,7 +250,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           registry-url: 'https://registry.npmjs.org'
       - run: make all
       - run: >-

.github/workflows/format.yaml

@@ -8,7 +8,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './lib/package-lock.json'
       - run: make format

.github/workflows/large-tests.yaml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './lib/package-lock.json'
       - run: npm ci
@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './cli/package-lock.json'
       - uses: actions/download-artifact@v4
@@ -74,7 +74,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           cache: 'npm'
           cache-dependency-path: './web-app/package-lock.json'
       - uses: actions/download-artifact@v4

.nvmrc

@@ -1 +1 @@
-20
+22

cli/src/cli.ts

@@ -1,4 +1,3 @@
-import './polyfills.js';
 import { createWriteStream, openAsBlob } from 'node:fs';
 import { readFile, stat, writeFile } from 'node:fs/promises';
 import { Writable } from 'node:stream';

cli/src/polyfills.ts

@@ -62,7 +62,7 @@
     "test": "npm run build && npm run test:with-server",
     "test:with-server": "node dist/web/tests/server.js & trap \"node dist/web/tests/stopServer.js\" EXIT; npm run test:mocha && npm run test:wtr && npm run test:browser && npm run coverage:merge",
     "test:browser": "npx webpack --config webpack.test.config.cjs && npx karma start karma.conf.cjs",
-    "test:mocha": "c8 --exclude=\"dist/web/tests/**/*\" --report-dir=./coverage/mocha mocha 'dist/web/tests/mocha/**/*.spec.js' --file dist/web/tests/mocha/setup.js && npx c8 report --reporter=json --report-dir=./coverage/mocha",
+    "test:mocha": "c8 --exclude=\"dist/web/tests/**/*\" --report-dir=./coverage/mocha mocha 'dist/web/tests/mocha/**/*.spec.js' && npx c8 report --reporter=json --report-dir=./coverage/mocha",
     "test:wtr": "web-test-runner",
     "watch": "(trap 'kill 0' SIGINT; npm run build && (npm run build:watch & npm run test -- --watch))"
   },

lib/package.json

@@ -394,7 +394,7 @@ export class Client {
         }
       }
       if (
-        avs.length != scope.attributes?.length ||
+        avs.length != (scope.attributes?.length || 0) ||
         !avs.map(({ fqn }) => fqn).every((a) => fqns.indexOf(a) >= 0)
       ) {
         throw new ConfigurationError(

lib/tdf3/src/client/index.ts

@@ -1,5 +1,3 @@
-import './mocha/setup.js';
-
 import * as jose from 'jose';
 import { createServer, IncomingMessage, RequestListener } from 'node:http';