Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abstract BaseWallet #3514

Open
jamshale opened this issue Feb 13, 2025 · 1 comment
Open

Remove abstract BaseWallet #3514

jamshale opened this issue Feb 13, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jamshale
Copy link
Contributor

We have switched to only using the AskarWallet wallet class and have no plans on supporting another wallet type. We should remove the abstract BaseWallet. This will help simplify the codebase and also helps from a developer perspective for ease of navigating the codebase into the wallet functionality.

@jamshale jamshale added the good first issue Good for newcomers label Feb 13, 2025
@ff137
Copy link
Contributor

ff137 commented Feb 13, 2025

My 2c worth here is that adding wallet abstraction again later would obviously be much harder. Even though it's not foreseeable to support anything besides askar now, that might change in the future.

Unless there is a conscious decision that acapy will only ever run with askar, I think the wallet abstraction might be worth keeping, just to have the scaffolding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants