Skip to content

Provide more meaningful names for some source files and built artefacts #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaifroid opened this issue Nov 26, 2022 · 2 comments · Fixed by #14 · May be fixed by #18
Closed

Provide more meaningful names for some source files and built artefacts #15

Jaifroid opened this issue Nov 26, 2022 · 2 comments · Fixed by #14 · May be fixed by #18
Labels
build Code relating to building or publishing assets

Comments

@Jaifroid
Copy link
Collaborator

Jaifroid commented Nov 26, 2022

Currently at least one key source file has a misleading name: demo_file_api.cpp. Likewise, the two most important generated files are simply a.out.js and a.out.wasm. The first should be named something like bindings.cpp (but please advise on the most accurate name in a cpp context). And I would like the generated files to be named libzim-wasm.js and libzim-wasm.wasm, as this would fit with the naming schema of our other Emscripten WASMs in Kiwix JS.

I think I know how to rename demo_file_api.cpp throughout the project, but I am a bit stumped with how to rename the Emscripten output files. I cannot find any parameter that seems to provide the prefix a.out. The problem is that these names are hard-coded in a.out.js, and it would be good to be able to generate ready-to-use files that don't need any internal patching.

@mgautierfr Is this something you can help with?

@Jaifroid Jaifroid added help wanted Extra attention is needed build Code relating to building or publishing assets labels Nov 26, 2022
@mgautierfr
Copy link
Collaborator

a.out is the default name for generated file if you don't provide one. Try using the -o option (-o libzim-wasm.js)

@Jaifroid
Copy link
Collaborator Author

Thanks, I managed to work it out in #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building or publishing assets
Projects
None yet
2 participants