-
-
Notifications
You must be signed in to change notification settings - Fork 27
[next-major] Remove metadata conversion from python-libzim #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
sir is this issue still open |
As per the issue, the current implementation in python-libzim automatically converts certain types of metadata (such as datetime.date and datetime.datetime objects) when they are added. The conversion includes: Converting dates to a YYYY-MM-DD string and encoding in UTF-8. Inconsistent Type Handling: Not all types are handled consistently, such as lists (e.g., tags) not being converted to strings. Remove date conversion: Stop automatically converting datetime.date and datetime.datetime objects into strings. **This will: Make python-libzim a more straightforward wrapper that doesn’t enforce unnecessary transformations. Let me know your thoughts or if you'd like to discuss further. Best regards, |
I'm sorry, but I won't read your comment. This is way too long/verbose and using way too much emphasis for something as straightforward as removing few lines of code. Propose a PR, but please be sharp. |
I believe we have a PR already that's ready and awaits that next major |
Indeed ! @aryanA101a PR is ready |
Cannot assign aryanA101a so assigning myself so that it is clear |
When adding metadatas, the python-libzim is doing a conversion for some types.
This should be removed because:
This would need a major release since it is a breaking change.
The text was updated successfully, but these errors were encountered: