Removed generyc pyright: ignore statements

We should really ban wide `pyright: ignore` statements and use specifix expections
wherever necessary (or comply!)
This fixes it in the current codebase

Author: rgaudin

src/zimscraperlib/rewriting/css.py

@@ -186,29 +186,27 @@ def _process_node(self, node: ast.Node):
             )
         elif isinstance(node, ast.FunctionBlock):
             if node.lower_name == "url":  # pyright: ignore[reportUnknownMemberType]
-                url_node: ast.Node = node.arguments[0]  # pyright: ignore
+                url_node: ast.Node = node.arguments[0]
                 new_url = self.url_rewriter(
-                    url_node.value,  # pyright: ignore
+                    getattr(url_node, "value", ""),
                     self.base_href,
                 ).rewriten_url
-                url_node.value = str(new_url)  # pyright: ignore
-                url_node.representation = (  # pyright: ignore
-                    f'"{serialize_url(str(new_url))}"'
+                setattr(url_node, "value", str(new_url))  # noqa: B010
+                setattr(  # noqa: B010
+                    url_node, "representation", f'"{serialize_url(str(new_url))}"'
                 )
 
             else:
                 self._process_list(
-                    node.arguments,  # pyright: ignore
+                    getattr(node, "arguments", []),
                 )
         elif isinstance(node, ast.AtRule):
-            self._process_list(node.prelude)  # pyright: ignore
-            self._process_list(node.content)  # pyright: ignore
+            self._process_list(node.prelude)
+            self._process_list(node.content)
         elif isinstance(node, ast.Declaration):
-            self._process_list(node.value)  # pyright: ignore
+            self._process_list(node.value)
         elif isinstance(node, ast.URLToken):
-            new_url = self.url_rewriter(
-                node.value, self.base_href
-            ).rewriten_url  # pyright: ignore
+            new_url = self.url_rewriter(node.value, self.base_href).rewriten_url
             node.value = new_url
             node.representation = f"url({serialize_url(new_url)})"
 

src/zimscraperlib/video/config.py

@@ -116,7 +116,7 @@ def buffersize(self, value):
     @property
     def video_scale(self):
         # remove "scale='" and "'" and return the value in between
-        return self.get("-vf")[7:-1] if self.get("-vf") else None  # pyright: ignore
+        return self.get("-vf", [])[7:-1] if self.get("-vf") else None
 
     @video_scale.setter
     def video_scale(self, value):

src/zimscraperlib/zim/__init__.py

@@ -9,10 +9,7 @@
     zim.items: item to add to creator
     zim.archive: read ZIM files, accessing or searching its content"""
 
-from beartype.claw import beartype_this_package
-from libzim.writer import Blob  # pyright: ignore
-
-beartype_this_package()
+from libzim.writer import Blob  # pyright: ignore[reportMissingModuleSource]
 
 from zimscraperlib.zim.archive import Archive
 from zimscraperlib.zim.creator import Creator

src/zimscraperlib/zim/archive.py

@@ -13,9 +13,9 @@
 
 from collections.abc import Iterable
 
-import libzim.reader  # pyright: ignore
-import libzim.search  # Query, Searcher  # pyright: ignore
-import libzim.suggestion  # SuggestionSearcher  # pyright: ignore
+import libzim.reader  # pyright: ignore[reportMissingModuleSource]
+import libzim.search  # pyright: ignore[reportMissingModuleSource]
+import libzim.suggestion  # pyright: ignore[reportMissingModuleSource]
 
 from zimscraperlib.zim._libkiwix import CounterMap, convertTags, parseMimetypeCounter
 

src/zimscraperlib/zim/creator.py

@@ -25,7 +25,7 @@
 import re
 import weakref
 
-import libzim.writer  # pyright: ignore
+import libzim.writer  # pyright: ignore[reportMissingModuleSource]
 import PIL.Image
 
 from zimscraperlib import logger

src/zimscraperlib/zim/indexing.py

@@ -5,7 +5,7 @@
 import io
 import pathlib
 
-import libzim.writer  # pyright: ignore
+import libzim.writer  # pyright: ignore[reportMissingModuleSource]
 
 try:
     import pymupdf

src/zimscraperlib/zim/items.py

@@ -13,7 +13,7 @@
 from collections.abc import Callable
 from typing import Any
 
-import libzim.writer  # pyright: ignore
+import libzim.writer  # pyright: ignore[reportMissingModuleSource]
 
 from zimscraperlib.download import stream_file
 from zimscraperlib.filesystem import get_content_mimetype, get_file_mimetype

src/zimscraperlib/zim/providers.py

@@ -15,7 +15,7 @@
 import pathlib
 from collections.abc import Generator
 
-import libzim.writer  # pyright: ignore
+import libzim.writer  # pyright: ignore[reportMissingModuleSource]
 import requests
 
 from zimscraperlib.download import _get_retry_adapter, stream_file
@@ -60,7 +60,7 @@ def __init__(
             self.fileobj.seek(0, io.SEEK_SET)
 
     def get_size(self) -> int:
-        return self.size  # pyright: ignore
+        return getattr(self, "size", -1)
 
     def gen_blob(self) -> Generator[libzim.writer.Blob, None, None]:
         yield libzim.writer.Blob(self.fileobj.getvalue())  # pragma: no cover
@@ -91,7 +91,7 @@ def get_size_of(url) -> int | None:
             return None
 
     def get_size(self) -> int:
-        return self.size  # pyright: ignore
+        return getattr(self, "size", -1)
 
     def gen_blob(self) -> Generator[libzim.writer.Blob, None, None]:  # pragma: no cover
         for chunk in self.resp.iter_content(10 * 1024):

tasks.py

@@ -2,7 +2,7 @@
 import os
 
 from invoke.context import Context
-from invoke.tasks import task  # pyright: ignore [reportUnknownVariableType]
+from invoke.tasks import task  # pyright: ignore[reportUnknownVariableType]
 
 use_pty = not os.getenv("CI", "")
 

tests/download/test_download.py

@@ -118,7 +118,7 @@ def test_first_block_download_custom_session(mocker, valid_http_url):
         headers=None,
         timeout=DEFAULT_WEB_REQUESTS_TIMEOUT,
     )
-    requests.Session.assert_not_called()  # pyright: ignore
+    requests.Session.assert_not_called()  # pyright: ignore[reportAttributeAccessIssue]
 
 
 @pytest.mark.slow
@@ -226,12 +226,13 @@ def test_youtube_download_nowait(tmp_path):
             BestMp4.get_options(target_dir=tmp_path),
             wait=False,
         )
-        assert future.running()  # pyright: ignore
+        assert future.running()  # pyright: ignore[reportAttributeAccessIssue]
         assert not yt_downloader.executor._shutdown
         done, not_done = concurrent.futures.wait(
-            [future], return_when=concurrent.futures.ALL_COMPLETED  # pyright: ignore
+            [future],  # pyright: ignore[reportArgumentType]
+            return_when=concurrent.futures.ALL_COMPLETED,
         )
-        assert future.exception() is None  # pyright: ignore
+        assert future.exception() is None  # pyright: ignore[reportAttributeAccessIssue]
         assert len(done) == 1
         assert len(not_done) == 0
 

tests/types/test_types.py

@@ -18,8 +18,6 @@ def test_constants():
     [
         ("hello.html", "text/html", None, None),
         ("some picture.png", "image/png", None, None),
-        # make sure we get default fallback on error
-        (b"-", "application/octet-stream", None, None),
         # make sure fallback is not returned on success
         ("hello.html", "text/html", "text/plain", None),
         # make sure fallback is returned on missing

tests/video/test_video.py

@@ -84,7 +84,9 @@ def test_config_build_from():
         assert idx != -1
         assert args[idx + 1] == str(getattr(config, attr))
     video_scale = config.video_scale
-    qmin, qmax = config.quantizer_scale_range  # pyright: ignore
+    qmin, qmax = (
+        config.quantizer_scale_range  # pyright: ignore[reportGeneralTypeIssues]
+    )
     assert args.index("-qmin") != -1 and args[args.index("-qmin") + 1] == str(qmin)
     assert args.index("-qmax") != -1 and args[args.index("-qmax") + 1] == str(qmax)
     assert (

tests/zim/test_indexing.py

@@ -1,7 +1,7 @@
 import io
 import pathlib
 
-import libzim.writer  # pyright: ignore
+import libzim.writer  # pyright: ignore[reportMissingModuleSource]
 import pytest
 
 from zimscraperlib.zim import Archive, Creator

tests/zim/test_metadata.py

@@ -118,7 +118,7 @@ def test_validate_tags_invalid(
     value: list[str] | str | int, exception: type, error: str
 ):
     with pytest.raises(exception, match=re.escape(error)):
-        metadata.TagsMetadata(value)  # pyright: ignore [reportArgumentType]
+        metadata.TagsMetadata(value)  # pyright: ignore[reportArgumentType]
 
 
 def test_validate_dedup_tags():

tests/zim/test_zim_creator.py

@@ -17,7 +17,7 @@
 from unittest.mock import call, patch
 
 import pytest
-from libzim.writer import Compression  # pyright: ignore
+from libzim.writer import Compression  # pyright: ignore[reportMissingModuleSource]
 
 from zimscraperlib.constants import UTF8
 from zimscraperlib.download import save_large_file, stream_file