Skip to content

Commit 842252e

Browse files
committed
--runinstalled is not necessary anymore with bootstrap convention, we are always installed
1 parent dcded70 commit 842252e

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

.github/workflows/Tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
pip install -e .[test,scripts]
3636
3737
- name: Run the tests
38-
run: inv coverage --args "--runslow --runinstalled -vvv"
38+
run: inv coverage --args "--runslow -vvv"
3939

4040
- name: Upload coverage report to codecov
4141
if: matrix.python == '3.12'

tests/conftest.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,16 @@ def pytest_addoption(parser):
1010
parser.addoption(
1111
"--runslow", action="store_true", default=False, help="run slow tests"
1212
)
13-
parser.addoption(
14-
"--runinstalled",
15-
action="store_true",
16-
default=False,
17-
help="run tests checking for installed features",
18-
)
1913

2014

2115
def pytest_configure(config):
2216
config.addinivalue_line("markers", "slow: mark test as slow to run")
23-
config.addinivalue_line(
24-
"markers", "installed: mark test as testing installed features"
25-
)
2617

2718

2819
def pytest_collection_modifyitems(config, items):
2920
skip_slow = pytest.mark.skip(reason="need --runslow option to run")
30-
skip_installed = pytest.mark.skip(reason="need --runinstalled option to run")
3121

3222
for item in items:
33-
if "installed" in item.keywords and not config.getoption("--runinstalled"):
34-
item.add_marker(skip_installed)
3523
if "slow" in item.keywords and not config.getoption("--runslow"):
3624
item.add_marker(skip_slow)
3725

tests/ogvjs/test_ogvjs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def prepare_ogvjs_folder(tmp_path, videojs_url, ogvjs_url, videojs_ogvjs_url):
4444
tmp_path.joinpath(member).rename(tmp_path.joinpath("videojs-ogvjs.js"))
4545

4646

47-
@pytest.mark.installed
4847
def test_installed_script():
4948
kwargs = {"universal_newlines": True, "stdout": subprocess.PIPE}
5049
script = subprocess.run(["/usr/bin/env", "fix_ogvjs_dist"], **kwargs, check=False)

0 commit comments

Comments
 (0)