fixup! Fix all type hints, qa and typing issues

Author: benoit74

Diff for: CHANGELOG.md

@@ -10,12 +10,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Add utility function to compute ZIM Tags #164, including deduplication #156
+- Expose new `optimization.get_optimization_method` to get the proper optimization method to call for a given image format
 
 ## Changed
 - **BREAKING** Renamed `zimscraperlib.image.convertion` to `zimscraperlib.image.conversion` to fix typo
 - **BREAKING** Many changes in type hints to match the real underlying code
 - **BREAKING** Force all boolean arguments (and some other non-obvious parameters) to be keyword-only in function calls for clarity / disambiguation (see ruff rule FBT002)
 - Prefer to use `IO[bytes]` to `io.BytesIO` when possible since it is more generic
+- **BREAKING** `i18n.NotFound` renamed `i18n.NotFoundError`
 
 ### Fixed
 

Diff for: src/zimscraperlib/image/optimization.py

@@ -29,6 +29,7 @@
 import os
 import pathlib
 import subprocess
+from typing import Callable
 
 import piexif
 from optimize_images.img_aux_processing import do_reduce_colors, rebuild_palette
@@ -311,7 +312,7 @@ def optimize_image(
         src.unlink()
 
 
-def get_optimization_method(fmt: str):
+def get_optimization_method(fmt: str) -> Callable:
     """Return the proper optimization method to call for a given image format"""
 
     def raise_error(*_, orig_format):

Diff for: src/zimscraperlib/image/probing.py

@@ -49,7 +49,7 @@ def solarize(r: int, g: int, b: int) -> tuple[int, int, int]:
 
 def is_hex_color(text: str) -> bool:
     """whether supplied text is a valid hex-formated color code"""
-    return re.search(r"^#(?:[0-9a-fA-F]{3}){1,2}$", text) is not None
+    return bool(re.search(r"^#(?:[0-9a-fA-F]{3}){1,2}$", text))
 
 
 def format_for(

Diff for: src/zimscraperlib/image/transformation.py

@@ -61,8 +61,6 @@ def resize_image(
         src.seek(0)
 
     if image_format is None:  # pragma: no cover
-        # not covered by test, no idea how to generate an image without a format
-        # returned by PIL
         raise ValueError("Impossible to guess format from src image")
 
     save_image(

Diff for: src/zimscraperlib/types.py

@@ -39,7 +39,7 @@
 def get_mime_for_name(
     filename: str | pathlib.Path,
     fallback: str | None = FALLBACK_MIME,
-    no_ext_to=ARTICLE_MIME,
+    no_ext_to: str | None = ARTICLE_MIME,
 ) -> str | None:
     """MIME-Type string from a filename
 

Diff for: src/zimscraperlib/zim/creator.py

@@ -86,7 +86,7 @@ def mimetype_for(
             or mimetype.startswith("text/")
         ):
             mimetype = get_mime_for_name(
-                fpath if fpath else path, mimetype, mimetype  # pyright: ignore
+                filename=fpath if fpath else path, fallback=mimetype, no_ext_to=mimetype
             )
     return mimetype
 

Diff for: src/zimscraperlib/zim/filesystem.py

@@ -105,14 +105,14 @@ def add_redirects_to_zim(
     if redirects_file:
         with open(redirects_file) as fh:
             for linenumber, line in enumerate(fh.readlines()):
-                matchs = re.match(r"^(.)\t(.+)\t(.*)\t(.+)$", line)
-                if not matchs:
+                match = re.match(r"^(.)\t(.+)\t(.*)\t(.+)$", line)
+                if not match:
                     logger.warning(
                         f"Redirects file: line {linenumber} does not match expected "
                         f"regexp: {line}"
                     )
                     continue
-                namespace, path, title, target_url = matchs.groups()
+                namespace, path, title, target_url = match.groups()
                 if namespace.strip():
                     path = f"{namespace.strip()}/{path}"
                 zim_file.add_redirect(path, target_url, title)