Skip to content

Add a less generic subsclass of StaticItem #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benoit74 opened this issue Feb 12, 2024 · 3 comments
Closed

Add a less generic subsclass of StaticItem #130

benoit74 opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

As discussed in #109, we can benefit from creating a less generic subclass of StaticItem with more strongly typed arguments than the very generic **kwargs we have in StaticItem.

This less generic class would serve >80% of the scraper needs.

@benoit74 benoit74 added the enhancement New feature or request label Feb 12, 2024
@benoit74 benoit74 added this to the 3.3.0 milestone Feb 12, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Feb 13, 2024

@rgaudin do you think there is something left to do on this issue after #132 last changes?

I had a look at all openZIM codebase and did not find anything which is not covered.

Most scrapers are using either add_item_for or add_redirect anyway.

The only thing we forgot to perform is the modification of add_item_for to use new StaticItem parameters. But this is not really related to this issue.

@rgaudin
Copy link
Member

rgaudin commented Feb 13, 2024

I agree ; we can close this

@benoit74 benoit74 modified the milestones: 3.3.0, 3.2.1 Feb 14, 2024
@benoit74
Copy link
Collaborator Author

Fixed by #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants