diff --git a/CHANGELOG.md b/CHANGELOG.md index 3674f210..7d1ad35c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ * added `wait` option in `YoutubeDownloader` to allow parallelism while using context manager * do not use extension for finding format in `ensure_matches()` in `image.optimization` module * added `VideoWebmHigh` and `VideoMp4High` presets for high quality WebM and Mp4 convertion respectively +* updated presets `WebpHigh`, `JpegMedium`, `JpegLow` and `PngMedium` in `image.presets` # 1.3.3 diff --git a/src/zimscraperlib/image/presets.py b/src/zimscraperlib/image/presets.py index 96e1c211..abd6eb60 100644 --- a/src/zimscraperlib/image/presets.py +++ b/src/zimscraperlib/image/presets.py @@ -48,7 +48,7 @@ class WebpHigh: options = { "lossless": False, - "quality": 60, + "quality": 90, "method": 6, } @@ -136,7 +136,7 @@ class PngMedium: VERSION = 1 options = { - "reduce_colors": True, + "reduce_colors": False, "remove_transparency": False, "fast_mode": False, } @@ -169,7 +169,7 @@ class JpegLow: options = { "quality": 45, "keep_exif": False, - "fast_mode": False, + "fast_mode": True, } @@ -185,7 +185,7 @@ class JpegMedium: options = { "quality": 65, "keep_exif": False, - "fast_mode": False, + "fast_mode": True, } diff --git a/tests/conftest.py b/tests/conftest.py index 8aa8dd2d..142705b3 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -105,4 +105,4 @@ def gif_image(): @pytest.fixture(scope="module") def webp_image(): - return file_src("whitewater.webp") + return file_src("ninja.webp") diff --git a/tests/files/ninja.webp b/tests/files/ninja.webp new file mode 100644 index 00000000..fb83af14 Binary files /dev/null and b/tests/files/ninja.webp differ diff --git a/tests/files/whitewater.webp b/tests/files/whitewater.webp deleted file mode 100644 index c833c5d4..00000000 Binary files a/tests/files/whitewater.webp and /dev/null differ diff --git a/tests/image/test_image.py b/tests/image/test_image.py index cf936b34..5d1a5c58 100644 --- a/tests/image/test_image.py +++ b/tests/image/test_image.py @@ -333,7 +333,7 @@ def test_optimize_image_allow_convert(png_image, tmp_path): [ (WebpLow(), 1, {"lossless": False, "quality": 40, "method": 6}, "webp"), (WebpMedium(), 1, {"lossless": False, "quality": 50, "method": 6}, "webp"), - (WebpHigh(), 1, {"lossless": False, "quality": 60, "method": 6}, "webp"), + (WebpHigh(), 1, {"lossless": False, "quality": 90, "method": 6}, "webp"), ( GifLow(), 1, @@ -382,7 +382,7 @@ def test_optimize_image_allow_convert(png_image, tmp_path): ( PngMedium(), 1, - {"reduce_colors": True, "remove_transparency": False, "fast_mode": False}, + {"reduce_colors": False, "remove_transparency": False, "fast_mode": False}, "png", ), ( @@ -391,11 +391,11 @@ def test_optimize_image_allow_convert(png_image, tmp_path): {"reduce_colors": False, "remove_transparency": False, "fast_mode": True}, "png", ), - (JpegLow(), 1, {"quality": 45, "keep_exif": False, "fast_mode": False}, "jpg"), + (JpegLow(), 1, {"quality": 45, "keep_exif": False, "fast_mode": True}, "jpg"), ( JpegMedium(), 1, - {"quality": 65, "keep_exif": False, "fast_mode": False}, + {"quality": 65, "keep_exif": False, "fast_mode": True}, "jpg", ), (JpegHigh(), 1, {"quality": 80, "keep_exif": True, "fast_mode": True}, "jpg"),