-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SVG favicon #148
Comments
@mgautierfr could you have a look please, I'm a bit stuck given I don't know how to extract the illustration to at least check this |
It's the 48x48px transparent PNG that's in scraperlib for dev which is used in warc2zim as fallback
|
I had to read the log three times to find the issue:
|
SVGs are simply not supported by Pillow: https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html @rgaudin: is this intended / well known? |
I've found openzim/python-scraperlib#113 and openzim/python-scraperlib#80 but I'm not sure this is 100% related |
Until then, I manually converted the SVG to PNG and pushed it to Zimfarm drive. |
This has to be implemented in openzim/python-scraperlib#113 indeed (hopefully will be done in 3.4.0) |
From the 100r.co ZIM, it looks like the conversion of a SVG illustration to PNG is failing or at least not producing a nice result.
See https://dev.library.kiwix.org/#lang=&q=grid, where there is no icon displayed (while other ZIMs created with the same zimit2 docker image are ok).
Recipe configuration: https://farm.openzim.org/recipes/100r.co/config
I don't know which tool I could use (aside from C++ source code I don't master at all) to extract the Illustration from the ZIM manually to check what is inside the ZIM.
The text was updated successfully, but these errors were encountered: